8340554: Improve MessageFormat readObject checks

[justin-curtis-lu]

Please review this PR which improves the readObject logic for j.text.MessageFormat.

No offset should be larger than the pattern length. We already ensure the offsets when consumed backwards are equal/descending. The existing first/initial check was off by 1 since it was checking against the pattern length + 1; (see L2040 and L2043).

Please see the JBS issue for further info and other test details.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8340554: Improve MessageFormat readObject checks (Bug - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21570/head:pull/21570
$ git checkout pull/21570

Update a local copy of the PR:
$ git checkout pull/21570
$ git pull https://git.openjdk.org/jdk.git pull/21570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21570

View PR using the GUI difftool:
$ git pr show -t 21570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21570.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340554: Improve MessageFormat readObject checks

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

• 98403b75df0a0737bdf082231f38c5c0019fe4c9: 8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error
• 9a7a850e2892990cf6755a0ccb19711816ad1b51: 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443
• de92fe375771315452fc5318abfd228fdd31c454: 8233451: (fs) Files.newInputStream() cannot be used with character special files
• 002de860813ff6bac8c6392f8c10d1c30fc5c09c: 8342673: Test serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java failed: waited too long for notify
• a21c558699646d44d071945c82203e2d68a4dcc3: 8342863: Use pattern matching for instanceof in equals methods of wrapper classes
• e64f0798be64d334b3ec2a918687aafc2031a8b7: 8342582: user.region for formatting number no longer works for 21.0.5
• 426da4bbad3a3eac15e8b17026ebad52b7c568ea: 8341975: Unable to set encoding for IO.println, IO.print and IO.readln
• a522d216b5bebbf103e5a823f0bba22cf1508883: 8342858: Make target mac-jdk-bundle fails on chmod command
• afb62f73499c09f4a7bde6f522fcd3ef1278e526: 8342683: Use non-short forward jump when passing stop()
• 964d8d2234595afaf4dfe48ea5cacdbfd3792d03: 8340445: [PPC64] Wrong ConditionRegister used in ppc64.ad: flagsRegCR0 cr1
• ... and 75 more: https://git.openjdk.org/jdk/compare/236c71cad9fa269518456c11edcfb353bbfc084d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (3730d628)
• 00: Full (dc3e952e)

[justin-curtis-lu]

/integrate

[openjdk[bot]]

Going to push as commit 7af46a6b424cadfe298958d774da0f21db58ecd3. Since your change was applied there have been 97 commits pushed to the master branch:

• 7d5eefa50673d6f7c5bd916f63271cf7898d6dee: 8342862: Gtest added by 8339507 appears to be causing 8GB build machines to hang
• d8c3b0f834c603fe115ef4ca442727948b7a834e: 8342768: GTest AssemblerX86.validate_vm failed: assert(VM_Version::supports_bmi1()) failed: tzcnt instruction not supported
• 3c14c2babbdfb46a77636ed80e083ef2f8be2b45: 8341566: Add Reader.of(CharSequence)
• b0ac633b2d0076d64b463b2a6ce19abf6b12c50f: 8342075: HttpClient: improve HTTP/2 flow control checks
• 85774b713edf8782f162ac25b61ce99a77e116f4: 8342882: RISC-V: Unify handling of jumps to runtime
• 2c31c8eeb42188ad6fd15eca50db4342cd791fb2: 8339730: Windows regression after removing ObjectMonitor Responsible
• f0b130e54f33d3190640ce33c991e35f27e9f812: 8339296: Record deconstruction pattern in switch fails to compile
• e96b4cf0a81914c6a615bb4f62ea3f139a4737f3: 8342387: C2 SuperWord: refactor and improve compiler/loopopts/superword/TestDependencyOffsets.java
• f7a61fce949ea2d15ec09d295c643d0c2eabea1e: 8342931: ProblemList failing tests from JDK-8335912
• 25c2f48d458bfd92423c311a887679ad3e1e4041: 8338544: Dedicated Array class descriptor implementation
• ... and 87 more: https://git.openjdk.org/jdk/compare/236c71cad9fa269518456c11edcfb353bbfc084d...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@justin-curtis-lu Pushed as commit 7af46a6b424cadfe298958d774da0f21db58ecd3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.