8342075: HttpClient: improve HTTP/2 flow control checks

[dfuch]

trafficstars

Please find here a fix that improves flow control in the HTTP/2 implementation.

The change makes sure that flow control issues are reported to the server as FLOW_CONTROL_ERROR. It also clarify how some system properties that allow to initialize flow control windows are handled, by documenting the full range of valid values (when applicable) and explaining what happens if the property points to a value that is out of range.

Bad flow control values in the SETTINGS frame will also cause a FLOW_CONTROL_ERROR to be reported.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Change requires CSR request JDK-8342834 to be approved
• [x] Commit message must refer to an issue

Issues

• JDK-8342075: HttpClient: improve HTTP/2 flow control checks (Bug - P4)
• JDK-8342834: HttpClient: improve HTTP/2 flow control checks (CSR)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21567/head:pull/21567
$ git checkout pull/21567

Update a local copy of the PR:
$ git checkout pull/21567
$ git pull https://git.openjdk.org/jdk.git pull/21567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21567

View PR using the GUI difftool:
$ git pr show -t 21567

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21567.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342075: HttpClient: improve HTTP/2 flow control checks

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

• 98403b75df0a0737bdf082231f38c5c0019fe4c9: 8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error
• 9a7a850e2892990cf6755a0ccb19711816ad1b51: 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443
• de92fe375771315452fc5318abfd228fdd31c454: 8233451: (fs) Files.newInputStream() cannot be used with character special files
• 002de860813ff6bac8c6392f8c10d1c30fc5c09c: 8342673: Test serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java failed: waited too long for notify
• a21c558699646d44d071945c82203e2d68a4dcc3: 8342863: Use pattern matching for instanceof in equals methods of wrapper classes
• e64f0798be64d334b3ec2a918687aafc2031a8b7: 8342582: user.region for formatting number no longer works for 21.0.5
• 426da4bbad3a3eac15e8b17026ebad52b7c568ea: 8341975: Unable to set encoding for IO.println, IO.print and IO.readln
• a522d216b5bebbf103e5a823f0bba22cf1508883: 8342858: Make target mac-jdk-bundle fails on chmod command
• afb62f73499c09f4a7bde6f522fcd3ef1278e526: 8342683: Use non-short forward jump when passing stop()
• 964d8d2234595afaf4dfe48ea5cacdbfd3792d03: 8340445: [PPC64] Wrong ConditionRegister used in ppc64.ad: flagsRegCR0 cr1
• ... and 75 more: https://git.openjdk.org/jdk/compare/236c71cad9fa269518456c11edcfb353bbfc084d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (bcbec677)
• 01: Full - Incremental (6ac7f5cd)
• 00: Full (a1f935fe)

[dfuch]

Thanks @turbanoff I applied your suggestions.

[dfuch]

/csr

[openjdk[bot]]

@dfuch has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@dfuch please create a CSR request for issue JDK-8342075 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[dfuch]

I see the CSR got approved. I'm running a last batch of tier2 tests and will integrate if they come back successful.

[dfuch]

/integrate

[openjdk[bot]]

Going to push as commit b0ac633b2d0076d64b463b2a6ce19abf6b12c50f. Since your change was applied there have been 93 commits pushed to the master branch:

• 85774b713edf8782f162ac25b61ce99a77e116f4: 8342882: RISC-V: Unify handling of jumps to runtime
• 2c31c8eeb42188ad6fd15eca50db4342cd791fb2: 8339730: Windows regression after removing ObjectMonitor Responsible
• f0b130e54f33d3190640ce33c991e35f27e9f812: 8339296: Record deconstruction pattern in switch fails to compile
• e96b4cf0a81914c6a615bb4f62ea3f139a4737f3: 8342387: C2 SuperWord: refactor and improve compiler/loopopts/superword/TestDependencyOffsets.java
• f7a61fce949ea2d15ec09d295c643d0c2eabea1e: 8342931: ProblemList failing tests from JDK-8335912
• 25c2f48d458bfd92423c311a887679ad3e1e4041: 8338544: Dedicated Array class descriptor implementation
• 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
• 28d23ada6dde007ed60b8538cc159afc62d76db3: 8340177: Malformed system classes loaded by bootloader crash the JVM in product builds
• 98403b75df0a0737bdf082231f38c5c0019fe4c9: 8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error
• 9a7a850e2892990cf6755a0ccb19711816ad1b51: 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443
• ... and 83 more: https://git.openjdk.org/jdk/compare/236c71cad9fa269518456c11edcfb353bbfc084d...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@dfuch Pushed as commit b0ac633b2d0076d64b463b2a6ce19abf6b12c50f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.