jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8331958: Update PC/SC Lite for Suse Linux to 2.3.0

Open valeriepeng opened this issue 1 year ago • 7 comments
trafficstars

Could someone please help review this PR? It updates the PCSC Lite headers and the relevant files to v2.3.0.

Thanks! Valerie


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8331958: Update PC/SC Lite for Suse Linux to 2.3.0 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21552/head:pull/21552
$ git checkout pull/21552

Update a local copy of the PR:
$ git checkout pull/21552
$ git pull https://git.openjdk.org/jdk.git pull/21552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21552

View PR using the GUI difftool:
$ git pr show -t 21552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21552.diff

Webrev

Link to Webrev Comment

valeriepeng avatar Oct 16 '24 21:10 valeriepeng

:wave: Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 16 '24 21:10 bridgekeeper[bot]

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331958: Update PC/SC Lite for Suse Linux to 2.3.0

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 216 new commits pushed to the master branch:

  • 964d8d2234595afaf4dfe48ea5cacdbfd3792d03: 8340445: [PPC64] Wrong ConditionRegister used in ppc64.ad: flagsRegCR0 cr1
  • 7131f053b0d26b62cbf0d8376ec117d6e8d79f9e: 8342043: Split Opaque4Node into OpaqueTemplateAssertionPredicateNode and OpaqueNotNullNode
  • 37cfaa8deb4cc15864bb6dc2c8a87fc97cff2f0d: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
  • a1ef81889bb5b9563f9295f979aee00f387be75f: 8342825: Fix order of @param tags in module java.desktop
  • cdad7286c6a099f5d0aa1f936e6201df9f3004cb: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY
  • 018db8c16a826b4b6b5eec76163616a07289b55a: 8342809: C2 hits "assert(is_If()) failed: invalid node class: Con" during IGVN due to unhandled top
  • f1f15370fa26e4c1121abadb8938c0126c6f4f24: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible
  • 476d0f19286c9d3c66d211352d0a8946b7039baf: 8339309: unused-variable warnings happen in libfontmanager
  • d6eddcdaf92f2352266ba519608879141997cd63: 8327624: Remove VM implementation that bypass verification for core reflection
  • 28147dab072b8f054f13350ea37ad64f7693b43d: 8341913: Support CDS heap dumping for Shenandoah and Epsilon
  • ... and 206 more: https://git.openjdk.org/jdk/compare/62acc9c174f23acd2807c8214ffc28d73799da16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 16 '24 21:10 openjdk[bot]

@valeriepeng The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 16 '24 21:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 16 '24 21:10 mlbridge[bot]

I see there is a COPYING file in the same directory as the header files. Does it need any update?

wangweij avatar Oct 17 '24 11:10 wangweij

I see there is a COPYING file in the same directory as the header files. Does it need any update?

That file has been the same, so no need to update it.

valeriepeng avatar Oct 22 '24 23:10 valeriepeng

If the upstream file hasn’t changed, that’s fine. I was just curious why the year included (for Ludovic) hasn’t been updated as well.

wangweij avatar Oct 23 '24 14:10 wangweij

If the upstream file hasn’t changed, that’s fine. I was just curious why the year included (for Ludovic) hasn’t been updated as well.

Yup, same here. Since the upstream file is the same, I only update the changed files. Thanks for the review~

valeriepeng avatar Oct 24 '24 20:10 valeriepeng

/integrate

valeriepeng avatar Oct 28 '24 18:10 valeriepeng

Going to push as commit d2e716eb72ea603fce50f0757a766ec623ef2faf. Since your change was applied there have been 274 commits pushed to the master branch:

  • a95374f588149d80068275a496ba4aa04b3bb4fd: 8343101: Rework BasicTest.testTemp test cases
  • 00fe9f7bdfd245791bca6b5b1b2d0a98d41af221: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file
  • 9f6d5b46ce2cfcdb39f94b8ac8621ee21f4e8740: 8343020: (fs) Add support for SecureDirectoryStream on macOS
  • 1341b81321fe77005ba68fba19c7d83e3fcb5fde: 8341666: FileInputStream doesn't support readAllBytes() or readNBytes(int) on pseudo devices
  • 52382e285fdf853c01605f8e0d7f3f5d34965802: 8338021: Support new unsigned and saturating vector operators in VectorAPI
  • e659d9da5d6198ad9c85efd6472e138a6a3961c2: 8342975: C2: Micro-optimize PhaseIdealLoop::Dominators()
  • 9f6211bcf1b46e4bfba2d128d9eb8457bc0cde51: 8341371: CDS cannot load archived heap objects with -XX:+UseSerialGC -XX:-UseCompressedOops
  • 120a9357b3cf63427a6c8539128b69b11b9beca3: 8342561: Metaspace for generated reflection classes is no longer needed
  • d5fb6b4a3cf4926acb333e7ee55f96fc76225631: 8339939: [JVMCI] Don't compress abstract and interface Klasses
  • a5ad974bec932c63ddc647c9986a513ae32ef663: 8343056: C2: Micro-optimize Node lists grow
  • ... and 264 more: https://git.openjdk.org/jdk/compare/62acc9c174f23acd2807c8214ffc28d73799da16...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 28 '24 18:10 openjdk[bot]

@valeriepeng Pushed as commit d2e716eb72ea603fce50f0757a766ec623ef2faf.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 28 '24 18:10 openjdk[bot]