8341903: Implementation of Scoped Values (Fourth Preview)

[theRealAph]

trafficstars

The fourth preview of scoped values.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Change requires CSR request JDK-8342205 to be approved
• [x] Commit message must refer to an issue
• [ ] Change requires a JEP request to be targeted

Issues

• JDK-8341903: Implementation of Scoped Values (Fourth Preview) (Enhancement - P4)
• JDK-8338456: JEP 487: Scoped Values (Fourth Preview) (JEP)
• JDK-8342205: Implementation of Scoped Values (Fourth Preview) (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21456/head:pull/21456
$ git checkout pull/21456

Update a local copy of the PR:
$ git checkout pull/21456
$ git pull https://git.openjdk.org/jdk.git pull/21456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21456

View PR using the GUI difftool:
$ git pr show -t 21456

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21456.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341903: Implementation of Scoped Values (Fourth Preview)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@theRealAph The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 06: Full - Incremental (84a436cc)
• 05: Full - Incremental (bc3bdc10)
• 04: Full - Incremental (7ec8e8de)
• 03: Full - Incremental (052553ea)
• 02: Full - Incremental (90a344a3)
• 01: Full - Incremental (0d178006)
• 00: Full (77e055b6)

[AlanBateman]

@theRealAph The update to src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java needs to be included too. Also test/jdk/jdk/internal/misc/ThreadFlock/WithScopedValue.java is updated in the loom repo, need to include that change too.

[wangweij]

The one line change in Subject.java is fine.

/label remove security

[openjdk[bot]]

@wangweij The security label was successfully removed.

[AlanBateman]

/csr

[openjdk[bot]]

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@theRealAph please create a CSR request for issue JDK-8341903 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[liach]

/jep jep-487

[openjdk[bot]]

@liach This pull request will not be integrated until the JEP-487 has been targeted.

[AlanBateman]

The changes in update 90a344a3 looks okay, just one example in the ScopedValue docs that was missed (the example is correct in the loom repo).

[theRealAph]

Tier1 and Tier2 done. I had one tier2 failure, java/net/URL/EarlyOrDelayedParsing.java. I don't think that's anything to do with these changes

[theRealAph]

/integrate

[openjdk[bot]]

Going to push as commit 3fab8e37bbebbb3930108b2015efe488b1fa1e97. Since your change was applied there have been 54 commits pushed to the master branch:

• 839de82c314697d7461b77caa9d85407e3578de3: 8332744: [REDO] 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version
• 8cb122119409fb13b4b9b2e74851207734d5c198: 8343532: Test test/hotspot/jtreg/runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linux ppc64le after JDK-8319343
• fbf9b96b6103250a2f72c3cbc47d73e9ddea6dbd: 8343480: Remove unnecessary @SuppressWarnings annotations (javadoc)
• f95097cc64f1d7647f8328b623e9bd9f1180b6d8: 8343482: Remove unnecessary @SuppressWarnings annotations (net)
• c799cad1de93aadfe60d9cbccb0499d7299f0598: 8343486: Remove unnecessary @SuppressWarnings annotations and -Xlint:-foo options
• 0b733e9a22fd786f3fd133faae3b00d31258e755: 8336874: WhiteBoxAPI: assert(!method->is_abstract() && (osr_bci == InvocationEntryBci || !method->is_native())) failed: cannot compile abstract/native methods
• 5890d9438bbde88b89070052926a2eafe13d7b42: 8333893: Optimization for StringBuilder append boolean & null
• c33a8f52b613e5eff02f572eda876cbbfc7c22cf: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
• 16feeb7a8e9a02fec4846179fcfbdc3a71b07fe5: 8343547: Restore accidentally removed annotations in LambdaForm from ClassFile API port
• f62fc4844125cc20a91dc2be39ba05a2d3aca8cf: 8342498: Add test for Allocation elimination after use as alignment reference by SuperWord
• ... and 44 more: https://git.openjdk.org/jdk/compare/5995786dbd69ed11dd1cacb2a3ac86e3e6f43ab7...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@theRealAph Pushed as commit 3fab8e37bbebbb3930108b2015efe488b1fa1e97.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.