jdk
jdk copied to clipboard
openjdk
8331008: Implement JEP 478: Key Derivation Function API (Preview)
Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See JEP 478.
Work was begun in another PR.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [ ] Change requires CSR request JDK-8331009 to be approved
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change requires a JEP request to be targeted
Issues
- JDK-8331008: Implement JEP 478: Key Derivation Function API (Preview) (Enhancement - P3)
- JDK-8189808: JEP 478: Key Derivation Function API (Preview) (JEP)
- JDK-8331009: Implement JEP 478: Key Derivation Function API (Preview) (CSR)
Reviewers
- Valerie Peng (@valeriepeng - Reviewer)
Contributors
- Rajan Halade
<[email protected]> - Weijun Wang
<[email protected]> - Valerie Peng
<[email protected]>
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20301/head:pull/20301
$ git checkout pull/20301
Update a local copy of the PR:
$ git checkout pull/20301
$ git pull https://git.openjdk.org/jdk.git pull/20301/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20301
View PR using the GUI difftool:
$ git pr show -t 20301
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20301.diff
Webrev
:wave: Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@driverkt This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8331008: Implement JEP 478: Key Derivation Function API (Preview)
Co-authored-by: Rajan Halade <[email protected]>
Co-authored-by: Weijun Wang <[email protected]>
Co-authored-by: Valerie Peng <[email protected]>
Reviewed-by: weijun, valeriep
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 735 new commits pushed to the master branch:
- 847cc5ebac43b83746d8f238c5f9ecf2972a2796: 8343173: Remove ZGC-specific non-JVMCI test groups
- 3fab8e37bbebbb3930108b2015efe488b1fa1e97: 8341903: Implementation of Scoped Values (Fourth Preview)
- 839de82c314697d7461b77caa9d85407e3578de3: 8332744: [REDO] 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version
- 8cb122119409fb13b4b9b2e74851207734d5c198: 8343532: Test test/hotspot/jtreg/runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linux ppc64le after JDK-8319343
- fbf9b96b6103250a2f72c3cbc47d73e9ddea6dbd: 8343480: Remove unnecessary @SuppressWarnings annotations (javadoc)
- f95097cc64f1d7647f8328b623e9bd9f1180b6d8: 8343482: Remove unnecessary @SuppressWarnings annotations (net)
- c799cad1de93aadfe60d9cbccb0499d7299f0598: 8343486: Remove unnecessary @SuppressWarnings annotations and -Xlint:-foo options
- 0b733e9a22fd786f3fd133faae3b00d31258e755: 8336874: WhiteBoxAPI: assert(!method->is_abstract() && (osr_bci == InvocationEntryBci || !method->is_native())) failed: cannot compile abstract/native methods
- 5890d9438bbde88b89070052926a2eafe13d7b42: 8333893: Optimization for StringBuilder append boolean & null
- c33a8f52b613e5eff02f572eda876cbbfc7c22cf: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
- ... and 725 more: https://git.openjdk.org/jdk/compare/996790c70f902d7840d0649a6b0867bed47c6537...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@driverkt The following labels will be automatically applied to this pull request:
compilercore-libssecurity
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
Webrevs
- 65: Full - Incremental (739072ca)
- 64: Full - Incremental (4819d340)
- 63: Full - Incremental (54d80694)
- 62: Full - Incremental (306a881a)
- 61: Full - Incremental (e89b4f27)
- 60: Full - Incremental (483ee9fd)
- 59: Full - Incremental (3e6ee389)
- 58: Full - Incremental (7677c00e)
- 57: Full - Incremental (5b44fad5)
- 56: Full - Incremental (224c0d20)
- 55: Full - Incremental (98f72883)
- 54: Full - Incremental (de3b0bfd)
- 53: Full - Incremental (5a4937ad)
- 52: Full - Incremental (888cda7f)
- 51: Full - Incremental (3399de1c)
- 50: Full - Incremental (1cfcc8d3)
- 49: Full - Incremental (9d2bc32b)
- 48: Full - Incremental (c0fa2f61)
- 47: Full - Incremental (97feb832)
- 46: Full - Incremental (bd1f658f)
- 45: Full - Incremental (315f90e6)
- 44: Full - Incremental (f786a381)
- 43: Full - Incremental (1edc431c)
- 42: Full - Incremental (b0e1110d)
- 41: Full - Incremental (1798541c)
- 40: Full - Incremental (ed6132c8)
- 39: Full - Incremental (6e9a7031)
- 38: Full - Incremental (ea5ba798)
- 37: Full - Incremental (2c1176c0)
- 36: Full - Incremental (e9c5f79e)
- 35: Full - Incremental (9a9d0987)
- 34: Full - Incremental (f513525c)
- 33: Full - Incremental (f279c7ff)
- 32: Full - Incremental (e7e5b3e5)
- 31: Full - Incremental (efde3bb8)
- 30: Full - Incremental (07480619)
- 29: Full - Incremental (856faa8c)
- 28: Full - Incremental (82791ac0)
- 27: Full - Incremental (dc0bd155)
- 26: Full - Incremental (5573558c)
- 25: Full - Incremental (81318f20)
- 24: Full - Incremental (8ea51c7c)
- 23: Full - Incremental (a35e98c9)
- 22: Full - Incremental (59b1743f)
- 21: Full - Incremental (25c17b26)
- 20: Full - Incremental (11696885)
- 19: Full - Incremental (e4400b6e)
- 18: Full - Incremental (4a0bc0ef)
- 17: Full - Incremental (6b7a75da)
- 16: Full - Incremental (deadc28d)
- 15: Full - Incremental (309a9253)
- 14: Full - Incremental (9f050b6a)
- 13: Full - Incremental (c9c3bc6c)
- 12: Full - Incremental (48395b86)
- 11: Full - Incremental (c6f491cd)
- 10: Full - Incremental (59a3f020)
- 09: Full - Incremental (dd2ee48f)
- 08: Full - Incremental (07d94056)
- 07: Full - Incremental (fe1159c2)
- 06: Full - Incremental (efa5246d)
- 05: Full - Incremental (f30c4b65)
- 04: Full - Incremental (7bedda25)
- 03: Full - Incremental (4fb26325)
- 02: Full - Incremental (26cffbf8)
- 01: Full - Incremental (ca63c111)
- 00: Full (12f71f86)
@driverkt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@driverkt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@driverkt Available commands:
- approval - request for maintainer's approval
- approve - null
- author - sets an overriding author to be used in the commit when the PR is integrated
- backport - create a backport
- cc - add or remove an additional classification label
- clean - Mark the backport pull request as a clean backport
- contributor - adds or removes additional contributors for a PR
- covered - used when employer has signed the OCA
- csr - require a compatibility and specification request (CSR) for this pull request
- help - shows this text
- integrate - performs integration of the changes in the PR
- issue - edit the list of issues that this PR solves
- jep - require a JDK Enhancement Proposal (JEP) for this pull request
- label - add or remove an additional classification label
- open - Set the pull request state to "open"
- reviewer - manage additional reviewers for a PR
- reviewers - set the number of additional required reviewers for this PR
- signed - used after signing the OCA
- solves - edit the list of issues that this PR solves
- sponsor - performs integration of a PR that is authored by a non-committer
- summary - updates the summary in the commit message
- test - used to run tests
@driverkt usage: /csr [needed|unneeded], requires that the issue the pull request refers to links to an approved CSR request.
@driverkt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@driverkt Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@seanjmullan all comments are resolved in the latest commit: https://github.com/openjdk/jdk/pull/20301/commits/442d1e95cad4da9a97b41cfdde1509f50b2b6cc4
@wangweij: Commit https://github.com/openjdk/jdk/pull/20301/commits/30dd26e2382486b6aaec6fd0798aa77c934fcb7a contains the synchronized block refactor as well as changes to address your other code review comments, except where I replied or asked a follow-up.
Going to push as commit 2a1ae0ff89a8ac364206b09059d9dc884adcc5ac.
Since your change was applied there have been 735 commits pushed to the master branch:
- 847cc5ebac43b83746d8f238c5f9ecf2972a2796: 8343173: Remove ZGC-specific non-JVMCI test groups
- 3fab8e37bbebbb3930108b2015efe488b1fa1e97: 8341903: Implementation of Scoped Values (Fourth Preview)
- 839de82c314697d7461b77caa9d85407e3578de3: 8332744: [REDO] 'internal proprietary API' diagnostics if --system is configured to an earlier JDK version
- 8cb122119409fb13b4b9b2e74851207734d5c198: 8343532: Test test/hotspot/jtreg/runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linux ppc64le after JDK-8319343
- fbf9b96b6103250a2f72c3cbc47d73e9ddea6dbd: 8343480: Remove unnecessary @SuppressWarnings annotations (javadoc)
- f95097cc64f1d7647f8328b623e9bd9f1180b6d8: 8343482: Remove unnecessary @SuppressWarnings annotations (net)
- c799cad1de93aadfe60d9cbccb0499d7299f0598: 8343486: Remove unnecessary @SuppressWarnings annotations and -Xlint:-foo options
- 0b733e9a22fd786f3fd133faae3b00d31258e755: 8336874: WhiteBoxAPI: assert(!method->is_abstract() && (osr_bci == InvocationEntryBci || !method->is_native())) failed: cannot compile abstract/native methods
- 5890d9438bbde88b89070052926a2eafe13d7b42: 8333893: Optimization for StringBuilder append boolean & null
- c33a8f52b613e5eff02f572eda876cbbfc7c22cf: 8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
- ... and 725 more: https://git.openjdk.org/jdk/compare/996790c70f902d7840d0649a6b0867bed47c6537...master
Your commit was automatically rebased without conflicts.
@driverkt Pushed as commit 2a1ae0ff89a8ac364206b09059d9dc884adcc5ac.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.