jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8335654: Remove stale hyperlink in divnode.cpp

Open jaskarth opened this issue 1 year ago • 4 comments

This is a trivial patch to remove a stale hyperlink in divnode.cpp. I noticed while reading the code that this link no longer points to the relevant Hacker's Delight code, and since the referenced code (archived version) is also embedded in the comment, let's remove it.

Thanks!


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8335654: Remove stale hyperlink in divnode.cpp (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20020/head:pull/20020
$ git checkout pull/20020

Update a local copy of the PR:
$ git checkout pull/20020
$ git pull https://git.openjdk.org/jdk.git pull/20020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20020

View PR using the GUI difftool:
$ git pr show -t 20020

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20020.diff

Webrev

Link to Webrev Comment

jaskarth avatar Jul 04 '24 03:07 jaskarth

:wave: Welcome back jkarthikeyan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 04 '24 03:07 bridgekeeper[bot]

@jaskarth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335654: Remove stale hyperlink in divnode.cpp

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • 38a578d547f39c3637d97f5e0242f4a69f3bbb31: 8334738: os::print_hex_dump should optionally print ASCII
  • 7b894bc4afa96bc04f0d58042f69becadb573e20: 8332786: When dumping static CDS archives, explicitly assert that we don't use a CDS archive
  • e01626cf09850f7b0af33cdb905ca8992266fe5b: 8335655: ProblemList serviceability/dcmd/vm tests failing after JDK-8322475
  • 3efa93ba1307cedf05609c0c04b2ba986a515f6e: 8335588: Fix -Wzero-as-null-pointer-constant warnings in calls to Node ctor
  • 587535c5b9bb258836b47c3a8c41ffb91bbfc131: 8334545: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails after JDK-8294960
  • 68ffec9800b798927a050900a2d47000aa18ef30: 8335479: JFR: Missing documentation for -XX:StartFlightRecording
  • 9a91865ff38f6fbb48b9aba5028e0b529d9bce76: 8335395: G1: Verification does not detect references into Free regions
  • 13b782c3de9a470a7cf1db9d5111ce19faf28729: 8334554: RISC-V: verify & fix perf of string comparison
  • 8aaec37ace102b55ee1387cfd1967ec3ab662083: 8322475: Extend printing for System.map
  • 19a8a2baa9e749c7527ff526b2794826f0cdebb3: 8335618: Serial: Remove unused definitions in SerialHeap
  • ... and 40 more: https://git.openjdk.org/jdk/compare/bb18498d71dddf49db9bdfac886aed9ae123651d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 04 '24 03:07 openjdk[bot]

@jaskarth The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jul 04 '24 03:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 04 '24 03:07 mlbridge[bot]

Thanks for the reviews!

/integrate

jaskarth avatar Jul 04 '24 14:07 jaskarth

Going to push as commit 3050ba017687ac13e1bbccdd1544d25f8eb2a747. Since your change was applied there have been 61 commits pushed to the master branch:

  • da0ffa8b7ff04eb5cbc0fcbe4b858f20d7e46405: 8334031: Generated JfrNativeSettings seems off
  • b0efd7740243916ba22178524ab2ede9e5436d94: 8314653: Metaspace: remove allocation guard feature
  • 6a472797a410a6fa27f50371b255054af0cd3c99: 8332072: Convert package.html files in java.naming to package-info.java
  • 7e378fccd8a4601c8b8e86aa2862c61e469c3a04: 8335667: Fix simple -Wzero-as-null-pointer-constant warnings in compiler code
  • ced99066354fc6a32c587b9e3c35b07e26d3452e: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages
  • 916db07e533cdc0fca2010751f7ebe54e6ada7b9: 8335532: [JVMCI] Export VM_Version::L1_line_size in JVMCI
  • c0604fb823d9f3b2e347a9857b11606b223ad8ec: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers
  • cf1be87279ddfb2a9fd272e0b245fccd7ec10972: 8335663: Fix simple -Wzero-as-null-pointer-constant warnings in C2 code
  • 0bb9c76288b5f63fe965c3276bb566cef5f51c50: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
  • 3e3f83f62c67caf960ca031439b022f915e1102a: 8335385: javac crash on unattributed piece of AST
  • ... and 51 more: https://git.openjdk.org/jdk/compare/bb18498d71dddf49db9bdfac886aed9ae123651d...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jul 04 '24 14:07 openjdk[bot]

@jaskarth Pushed as commit 3050ba017687ac13e1bbccdd1544d25f8eb2a747.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jul 04 '24 14:07 openjdk[bot]