8312125: Refactor CDS enum class handling

[iklam]

trafficstars

Please review this simple refactoring of the CDS code for handling enum classes. The code is moved to new files cdsEnumKlass.cpp/hpp. There's otherwise no change.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8312125: Refactor CDS enum class handling (Sub-task - P4)

Reviewers

• Matias Saavedra Silva (@matias9927 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20013/head:pull/20013
$ git checkout pull/20013

Update a local copy of the PR:
$ git checkout pull/20013
$ git pull https://git.openjdk.org/jdk.git pull/20013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20013

View PR using the GUI difftool:
$ git pr show -t 20013

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20013.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312125: Refactor CDS enum class handling

Reviewed-by: matsaave, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 3a87eb5c4606ce39970962895315567e8606eba7: 8335126: Shenandoah: Improve OOM handling
• 284671a1e4fb5bfe15b20b7f41fc24415b1235ed: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ...
• a9b7f42f29120a3cca0d341350ff03cae485e68b: 8333826: Update --release 23 symbol information for JDK 23 build 29
• d8c1c6ab0543c986280dcfa1c6c79e010a7b35fb: 8335604: Serial: Inline Generation::contiguous_available
• be3676f6bbc2d8041e43cf7bcfaee7fb9d864378: 8304484: CDS dynamic dumping incorrectly leads to "Error occurred during initialization of VM"
• cec222e46065fc15db3f2eb241d3607d605ab580: 8317611: Add a tool like jdeprscan to find usage of restricted methods
• 953c35eb5bff49ec5f7dbb25edd8a324b94318eb: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
• c34a1b7013b27a8a214f63387bd528a90342a416: 8335861: Problem list compiler/vectorization/TestFloat16VectorConvChain.java
• c5a668bb653feb3408a9efa3274ceabf9f01a2c7: 8334231: Optimize MethodData layout
• 540188fdebd089d4145eca18c0f95bf338cbcefc: 8334445: Parallel: Decouple maximum compaction from SoftReference clearing
• ... and 4 more: https://git.openjdk.org/jdk/compare/6f7f0f1de05fdc0f6a88ccd90b806e8a5c5074ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (fcd987fb)
• 01: Full - Incremental (49dc109e)
• 00: Full (64b77ecb)

[iklam]

Thanks @matias9927 @calvinccheung for the review /integrate

[openjdk[bot]]

@iklam This pull request has not yet been marked as ready for integration.

[iklam]

/integrate

[openjdk[bot]]

Going to push as commit 9c7a6eabb93c570fdb74076edc931576ed6be3e0. Since your change was applied there have been 17 commits pushed to the master branch:

• bb1f8a1698553d5962569ac8912edd0d7ef010dd: 8335904: Fix invalid comment in ShenandoahLock
• babf6df7d97e4beedb25e689634d999412c1e950: 8334757: AssertionError: Missing type variable in where clause
• 3733fe3a207078b585421cd2a098e808fafaa817: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @
• 3a87eb5c4606ce39970962895315567e8606eba7: 8335126: Shenandoah: Improve OOM handling
• 284671a1e4fb5bfe15b20b7f41fc24415b1235ed: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ...
• a9b7f42f29120a3cca0d341350ff03cae485e68b: 8333826: Update --release 23 symbol information for JDK 23 build 29
• d8c1c6ab0543c986280dcfa1c6c79e010a7b35fb: 8335604: Serial: Inline Generation::contiguous_available
• be3676f6bbc2d8041e43cf7bcfaee7fb9d864378: 8304484: CDS dynamic dumping incorrectly leads to "Error occurred during initialization of VM"
• cec222e46065fc15db3f2eb241d3607d605ab580: 8317611: Add a tool like jdeprscan to find usage of restricted methods
• 953c35eb5bff49ec5f7dbb25edd8a324b94318eb: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
• ... and 7 more: https://git.openjdk.org/jdk/compare/6f7f0f1de05fdc0f6a88ccd90b806e8a5c5074ef...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@iklam Pushed as commit 9c7a6eabb93c570fdb74076edc931576ed6be3e0.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.