jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8324089: Fix typo in the manual page for "jcmd" (man jcmd)

Open egahlin opened this issue 1 year ago • 4 comments
trafficstars

Could I have a review of a typo for JFR.start and JFR.dump?

Testing: tier1

Thanks Erik


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8324089: Fix typo in the manual page for "jcmd" (man jcmd) (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20003/head:pull/20003
$ git checkout pull/20003

Update a local copy of the PR:
$ git checkout pull/20003
$ git pull https://git.openjdk.org/jdk.git pull/20003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20003

View PR using the GUI difftool:
$ git pr show -t 20003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20003.diff

Webrev

Link to Webrev Comment

egahlin avatar Jul 03 '24 12:07 egahlin

:wave: Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 03 '24 12:07 bridgekeeper[bot]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324089: Fix typo in the manual page for "jcmd" (man jcmd)

Reviewed-by: mgronlun, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 9a91865ff38f6fbb48b9aba5028e0b529d9bce76: 8335395: G1: Verification does not detect references into Free regions
  • 13b782c3de9a470a7cf1db9d5111ce19faf28729: 8334554: RISC-V: verify & fix perf of string comparison
  • 8aaec37ace102b55ee1387cfd1967ec3ab662083: 8322475: Extend printing for System.map
  • 19a8a2baa9e749c7527ff526b2794826f0cdebb3: 8335618: Serial: Remove unused definitions in SerialHeap
  • cf4f2b53d6174a808f8b45f0bb848efd5bd91c3c: 8332517: G1: Refactor G1AllocRegion
  • 5a8af2b8b93672de9b3a3e73e6984506980da932: 8335615: Clean up left-overs from 8317721
  • 6923a5114b2a9f02f0d6f0fefc21141ac3b9322a: 8335607: Serial: Remove unused collection_attempt_is_safe
  • 5866b16dbca3f63770c8792d204dabdf49b59839: 8335411: RISC-V: Optimize encode_heap_oop when oop is not null
  • 6db4c6a772df856fc3099c32a5b2c102a30d360c: 8335536: Fix assertion failure in IdealGraphPrinter when append is true

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 03 '24 12:07 openjdk[bot]

@egahlin The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jul 03 '24 12:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 03 '24 16:07 mlbridge[bot]

/integrate

egahlin avatar Jul 04 '24 10:07 egahlin

Going to push as commit 0bb9c76288b5f63fe965c3276bb566cef5f51c50. Since your change was applied there have been 17 commits pushed to the master branch:

  • 3e3f83f62c67caf960ca031439b022f915e1102a: 8335385: javac crash on unattributed piece of AST
  • b20e8c8e85e0a0e96ae648f42ff803f1c83f6291: 8335397: Improve reliability of TestRecursiveMonitorChurn.java
  • 38a578d547f39c3637d97f5e0242f4a69f3bbb31: 8334738: os::print_hex_dump should optionally print ASCII
  • 7b894bc4afa96bc04f0d58042f69becadb573e20: 8332786: When dumping static CDS archives, explicitly assert that we don't use a CDS archive
  • e01626cf09850f7b0af33cdb905ca8992266fe5b: 8335655: ProblemList serviceability/dcmd/vm tests failing after JDK-8322475
  • 3efa93ba1307cedf05609c0c04b2ba986a515f6e: 8335588: Fix -Wzero-as-null-pointer-constant warnings in calls to Node ctor
  • 587535c5b9bb258836b47c3a8c41ffb91bbfc131: 8334545: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails after JDK-8294960
  • 68ffec9800b798927a050900a2d47000aa18ef30: 8335479: JFR: Missing documentation for -XX:StartFlightRecording
  • 9a91865ff38f6fbb48b9aba5028e0b529d9bce76: 8335395: G1: Verification does not detect references into Free regions
  • 13b782c3de9a470a7cf1db9d5111ce19faf28729: 8334554: RISC-V: verify & fix perf of string comparison
  • ... and 7 more: https://git.openjdk.org/jdk/compare/350f9c1947b0eab3ee233516ceefca1e25de9583...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jul 04 '24 10:07 openjdk[bot]

@egahlin Pushed as commit 0bb9c76288b5f63fe965c3276bb566cef5f51c50.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jul 04 '24 10:07 openjdk[bot]

/backport openjdk/jdk:jdk23

egahlin avatar Jul 04 '24 10:07 egahlin

@egahlin the backport was successfully created on the branch backport-egahlin-0bb9c762-jdk23 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk23, just click the following link:

:arrow_right: Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 0bb9c762 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 4 Jul 2024 and was reviewed by Markus Grönlund and Kevin Walls.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-egahlin-0bb9c762-jdk23:backport-egahlin-0bb9c762-jdk23
$ git checkout backport-egahlin-0bb9c762-jdk23
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-egahlin-0bb9c762-jdk23

openjdk[bot] avatar Jul 04 '24 10:07 openjdk[bot]