jdk icon indicating copy to clipboard operation
jdk copied to clipboard

WIP: Move ArrayWithFreeList to utilities

Open jdksjolen opened this issue 1 year ago • 4 comments
trafficstars

WIP:

  1. Move to utilities
  2. Use a small resizable_array such that len and cap can be templated and fixed array can be used
  3. Some tests

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20002/head:pull/20002
$ git checkout pull/20002

Update a local copy of the PR:
$ git checkout pull/20002
$ git pull https://git.openjdk.org/jdk.git pull/20002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20002

View PR using the GUI difftool:
$ git pr show -t 20002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20002.diff

jdksjolen avatar Jul 03 '24 10:07 jdksjolen

:wave: Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 03 '24 10:07 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jul 03 '24 10:07 openjdk[bot]

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jul 03 '24 10:07 openjdk[bot]

Bookmarking so I can remember to return to this when it's Ready for Review

TheShermanTanker avatar Jul 03 '24 13:07 TheShermanTanker

@jdksjolen This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 28 '24 17:08 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Sep 16 '24 12:09 mlbridge[bot]

@jdksjolen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 16 '24 13:10 bridgekeeper[bot]

Still awaiting review!

jdksjolen avatar Oct 24 '24 12:10 jdksjolen

@jdksjolen This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 21 '24 16:11 bridgekeeper[bot]

@jdksjolen This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Dec 19 '24 17:12 bridgekeeper[bot]