jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8335604: Serial: Inline Generation::contiguous_available

Open albertnetymk opened this issue 1 year ago • 4 comments

Trivial inlining a method.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8335604: Serial: Inline Generation::contiguous_available (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20000/head:pull/20000
$ git checkout pull/20000

Update a local copy of the PR:
$ git checkout pull/20000
$ git pull https://git.openjdk.org/jdk.git pull/20000/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20000

View PR using the GUI difftool:
$ git pr show -t 20000

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20000.diff

Webrev

Link to Webrev Comment

albertnetymk avatar Jul 03 '24 08:07 albertnetymk

:wave: Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 03 '24 08:07 bridgekeeper[bot]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335604: Serial: Inline Generation::contiguous_available

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 953c35eb5bff49ec5f7dbb25edd8a324b94318eb: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
  • c34a1b7013b27a8a214f63387bd528a90342a416: 8335861: Problem list compiler/vectorization/TestFloat16VectorConvChain.java
  • c5a668bb653feb3408a9efa3274ceabf9f01a2c7: 8334231: Optimize MethodData layout
  • 540188fdebd089d4145eca18c0f95bf338cbcefc: 8334445: Parallel: Decouple maximum compaction from SoftReference clearing
  • 3cce31ad8877ec62429981871bcb0067770f9ccb: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475
  • 55fd1ed228ea3c42aaf92579e5dcb818fe14351d: 8333890: Fatal error in auto-vectorizer with float16 kernel.
  • 02956ab6e161ca8556a73f328f79bcbfba997cbc: 8332163: C2 SuperWord: refactor PacksetGraph and SuperWord::output into VTransformGraph
  • 3f37c5718d676b7001e6a084aed3ba645745a144: 8335806: RISC-V: Corrected typos Bizarrely
  • 6f7f0f1de05fdc0f6a88ccd90b806e8a5c5074ef: 8333884: MemorySegment::reinterpret removes read-only property
  • b83766e59063a41ea8801ac9e7c15dce67727c62: 8335632: jdk/jfr/api/consumer/streaming/TestJVMExit.java failed with "Process [...] is no longer alive"
  • ... and 39 more: https://git.openjdk.org/jdk/compare/6c84e9c8cb71aac103901c0d92fe6ae51aabff15...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 03 '24 08:07 openjdk[bot]

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jul 03 '24 08:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 03 '24 08:07 mlbridge[bot]

Thanks for review.

/integrate

albertnetymk avatar Jul 08 '24 15:07 albertnetymk

Going to push as commit d8c1c6ab0543c986280dcfa1c6c79e010a7b35fb. Since your change was applied there have been 51 commits pushed to the master branch:

  • be3676f6bbc2d8041e43cf7bcfaee7fb9d864378: 8304484: CDS dynamic dumping incorrectly leads to "Error occurred during initialization of VM"
  • cec222e46065fc15db3f2eb241d3607d605ab580: 8317611: Add a tool like jdeprscan to find usage of restricted methods
  • 953c35eb5bff49ec5f7dbb25edd8a324b94318eb: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
  • c34a1b7013b27a8a214f63387bd528a90342a416: 8335861: Problem list compiler/vectorization/TestFloat16VectorConvChain.java
  • c5a668bb653feb3408a9efa3274ceabf9f01a2c7: 8334231: Optimize MethodData layout
  • 540188fdebd089d4145eca18c0f95bf338cbcefc: 8334445: Parallel: Decouple maximum compaction from SoftReference clearing
  • 3cce31ad8877ec62429981871bcb0067770f9ccb: 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475
  • 55fd1ed228ea3c42aaf92579e5dcb818fe14351d: 8333890: Fatal error in auto-vectorizer with float16 kernel.
  • 02956ab6e161ca8556a73f328f79bcbfba997cbc: 8332163: C2 SuperWord: refactor PacksetGraph and SuperWord::output into VTransformGraph
  • 3f37c5718d676b7001e6a084aed3ba645745a144: 8335806: RISC-V: Corrected typos Bizarrely
  • ... and 41 more: https://git.openjdk.org/jdk/compare/6c84e9c8cb71aac103901c0d92fe6ae51aabff15...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jul 08 '24 15:07 openjdk[bot]

@albertnetymk Pushed as commit d8c1c6ab0543c986280dcfa1c6c79e010a7b35fb.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jul 08 '24 15:07 openjdk[bot]