8335475: ClassBuilder incorrectly calculates max_locals in some cases

[liach]

Please review this clean backport of #19981 onto JDK 23, fixing StackMapGenerator generating static methods with no declared local variable a max local of 1.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8335475: ClassBuilder incorrectly calculates max_locals in some cases (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19993/head:pull/19993
$ git checkout pull/19993

Update a local copy of the PR:
$ git checkout pull/19993
$ git pull https://git.openjdk.org/jdk.git pull/19993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19993

View PR using the GUI difftool:
$ git pr show -t 19993

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19993.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back liach! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335475: ClassBuilder incorrectly calculates max_locals in some cases

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the jdk23 branch:

• b415b981397395eac298dfc841d1a9d012f62501: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 90d5b5b4c497ac99d0e2ade689b6459fffea3e2a: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
• 653c481d71b3c5c6bc1e867d88a560495557876c: 8335479: JFR: Missing documentation for -XX:StartFlightRecording
• 10b28babe53821fcdeef3a1aa0712feb7cd67529: 8322812: Manpage for jcmd is missing JFR.view command
• d383365ea4196cd5f40de217547392b820c4ad01: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[openjdk[bot]]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (e72ea3c2)

[liach]

/integrate

[openjdk[bot]]

Going to push as commit 2f60d3684843e42c2c4c3bf628ac6d62dcdfcadb. Since your change was applied there have been 5 commits pushed to the jdk23 branch:

• b415b981397395eac298dfc841d1a9d012f62501: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 90d5b5b4c497ac99d0e2ade689b6459fffea3e2a: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
• 653c481d71b3c5c6bc1e867d88a560495557876c: 8335479: JFR: Missing documentation for -XX:StartFlightRecording
• 10b28babe53821fcdeef3a1aa0712feb7cd67529: 8322812: Manpage for jcmd is missing JFR.view command
• d383365ea4196cd5f40de217547392b820c4ad01: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@liach Pushed as commit 2f60d3684843e42c2c4c3bf628ac6d62dcdfcadb.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.