jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8331385: G1: Prefix HeapRegion helper classes with G1

Open tschatzl opened this issue 1 year ago • 4 comments
trafficstars

Hi all,

after JDK-8330694 which renamed HeapRegion to G1HeapRegion, there were a few related helper classes in this CR that were not renamed.

It's purely mechanical renaming without even further renaming of files etc.

This change updates them.

(Fwiw, the "Viewed" checkbox at the top right of the file change helps a lot review this change incrementally)

Testing: tier1, tier4, tier5

Thanks, Thomas


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8331385: G1: Prefix HeapRegion helper classes with G1 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19967/head:pull/19967
$ git checkout pull/19967

Update a local copy of the PR:
$ git checkout pull/19967
$ git pull https://git.openjdk.org/jdk.git pull/19967/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19967

View PR using the GUI difftool:
$ git pr show -t 19967

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19967.diff

Webrev

Link to Webrev Comment

tschatzl avatar Jul 01 '24 09:07 tschatzl

:wave: Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 01 '24 09:07 bridgekeeper[bot]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331385: G1: Prefix HeapRegion helper classes with G1

Reviewed-by: ayang, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 1ef34c183315b70ddc27c177a2867e30132609f5: 8335475: ClassBuilder incorrectly calculates max_locals in some cases
  • 27982c8f5dad0e2d080846f803055c84bac9fddd: 8327854: Test java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpStatefulTest.java failed with RuntimeException
  • a3479576c9b3e557cdc04e0984da6350e985dcc9: 8335291: Problem list all SA core file tests on macosx-aarch64 due to JDK-8318754
  • 153b12b9df87fdf8122cae3bf7f13078f55f7101: 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers
  • 685e5878b823fa5e3ae88ffd76de6507d6057af2: 8334816: compiler/c2/irTests/TestIfMinMax.java fails after 8334629
  • dd74e7f8c1570ed34c89f4aca184f5668e4471db: 8335147: Serial: Refactor TenuredGeneration::promote
  • a537e87d2d2c6bff63f63bb436e3e919740221ce: 8335530: Java file extension missing in AuthenticatorTest
  • 4060b35b1d00fccbec4b20353063f77c43ecc686: 8335298: Fix -Wzero-as-null-pointer-constant warning in G1CardSetContainers
  • 9046d7aee3082b6cbf79876efc1c508cb893caad: 8335390: C2 MergeStores: wrong result with Unsafe
  • 318d9acadf305f9d7d0cd8bb54b41506dd9914a8: 8335369: Fix -Wzero-as-null-pointer-constant warnings in ImmutableOopMapBuilder
  • ... and 5 more: https://git.openjdk.org/jdk/compare/0a6ffa57954ddf4f92205205a5a1bada813d127a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 01 '24 09:07 openjdk[bot]

@tschatzl The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Jul 01 '24 09:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 02 '24 07:07 mlbridge[bot]

Thanks @albertnetymk @dholmes-ora for your reviews. /integrate

tschatzl avatar Jul 05 '24 07:07 tschatzl

Going to push as commit 4ec1ae109710aa150e27acf5706475d335c4655c. Since your change was applied there have been 60 commits pushed to the master branch:

  • b9d8056d5c1528198ad373f9b4a09547e2fcabd6: 8332124: Jcmd should recognise options that look like requests for help
  • cff9e246cc2fbd3914f40bb71daa85dcf7731396: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs
  • f4fa35e28b9881729ac47c8518e758bba676fdec: 8330954: since-checker - Fix remaining @ since tags in java.base
  • 3050ba017687ac13e1bbccdd1544d25f8eb2a747: 8335654: Remove stale hyperlink in divnode.cpp
  • da0ffa8b7ff04eb5cbc0fcbe4b858f20d7e46405: 8334031: Generated JfrNativeSettings seems off
  • b0efd7740243916ba22178524ab2ede9e5436d94: 8314653: Metaspace: remove allocation guard feature
  • 6a472797a410a6fa27f50371b255054af0cd3c99: 8332072: Convert package.html files in java.naming to package-info.java
  • 7e378fccd8a4601c8b8e86aa2862c61e469c3a04: 8335667: Fix simple -Wzero-as-null-pointer-constant warnings in compiler code
  • ced99066354fc6a32c587b9e3c35b07e26d3452e: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages
  • 916db07e533cdc0fca2010751f7ebe54e6ada7b9: 8335532: [JVMCI] Export VM_Version::L1_line_size in JVMCI
  • ... and 50 more: https://git.openjdk.org/jdk/compare/0a6ffa57954ddf4f92205205a5a1bada813d127a...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jul 05 '24 07:07 openjdk[bot]

@tschatzl Pushed as commit 4ec1ae109710aa150e27acf5706475d335c4655c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jul 05 '24 07:07 openjdk[bot]