jdk
jdk copied to clipboard
openjdk
c1
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [ ] Change must not contain extraneous whitespace
- [ ] Commit message must refer to an issue
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19947/head:pull/19947
$ git checkout pull/19947
Update a local copy of the PR:
$ git checkout pull/19947
$ git pull https://git.openjdk.org/jdk.git pull/19947/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19947
View PR using the GUI difftool:
$ git pr show -t 19947
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19947.diff
:wave: Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@suchismith1993 This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8332423: [PPC64] Remove C1_MacroAssembler::call_c_with_frame_resize
Reviewed-by: mdoerr, varadam
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 132 new commits pushed to the master branch:
- b389bb456726184e4691777b1bb02d4b8a8a3f97: 8339540: Unify include requirements for PlatformMonitor/Mutex constructors/destructors
- ab656c3aab8157ed8e70bc126881cbadc825de93: 8339579: ZGC: Race results in only one of two remembered sets being cleared
- a505a1dda3bc6975bb11f390543b38618ddf2626: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation
- 6be927260a84b1d7542167e526ff41f7dc26cab0: 8338591: Improve performance of MemorySegment::copy
- cb9f5c5791d17afbf72f7debe8013b77e45b3b56: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo
- 340e131d616bd81ccd0bdc3817aead0284014cac: 8338971: IGV: Add incrementally inlined method name to phase name
- 2305d18e8d53dbbf341b580b60f9ed21f408bff1: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
- 96a0502d624e3eff1b00a7c63e8b3a27870b475e: 8339369: G1: TestVerificationInConcurrentCycle.java fails with "Missing rem set entry" when using "-XX:G1RSetUpdatingPauseTimePercent=0 -XX:G1UpdateBufferSize=2"
- 28de44da71871bec7648f01a4df2faee43fa43b6: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'
- 96df5a6d8f90c988b354dbe6bdc510aa4b8ee98b: 8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after JDK-8338257
- ... and 122 more: https://git.openjdk.org/jdk/compare/5671f836039ef1683e3e9ce5b7cf0fa2f1860e2d...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr, @varada1110) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@suchismith1993 The following label will be automatically applied to this pull request:
hotspot-compiler
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@suchismith1993 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@suchismith1993 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout c1runtime
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
Webrevs
- 09: Full - Incremental (b02b1982)
- 08: Full - Incremental (b63c9591)
- 07: Full - Incremental (73eead7f)
- 06: Full - Incremental (1db20f59)
- 05: Full - Incremental (7c7de0ec)
- 04: Full - Incremental (f7d7854c)
- 03: Full - Incremental (2230d6c7)
- 02: Full - Incremental (7c0816bf)
- 01: Full - Incremental (2b07a3bc)
- 00: Full (20f8f106)
@suchismith1993 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@suchismith1993 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@TheRealMDoerr i would need another review for this right ?
Yes, please. It's not classified as trivial. Maybe you can ask somebody from your team.
LGTM! tier1 testing done on linux-ppc64le with both release and fastdebug, no related failures. Thank you
You effectively changed the type from
relocInfo::runtime_call_typetorelocInfo::nonein c1_LIRAssembler_ppc.cpp. This is causing problems with ABIv1. The VM seems to work when switching off C1 on AIX. So, the other files should be ok.
So do we then call in c1_LIRA using __ call_c(copyfunc_addr, relocInfo::runtime_call_type); ?
You effectively changed the type from
relocInfo::runtime_call_typetorelocInfo::nonein c1_LIRAssembler_ppc.cpp. This is causing problems with ABIv1. The VM seems to work when switching off C1 on AIX. So, the other files should be ok.So do we then call in c1_LIRA using __ call_c(copyfunc_addr, relocInfo::runtime_call_type); ?
Yes, for all 4 call_c in c1_LIRAssembler_ppc.cpp.
@varada1110: Can you use "Approve" instead of "Comment", please? Otherwise, your review doesn't get recorded properly.
Test results look good this time. I think it's good to go.
Hi Martin, you mean the results for AIX ?
Test results look good this time. I think it's good to go.
Hi Martin, you mean the results for AIX ?
Yes. I've also retested on linux ppc64le.
@suchismith1993 Your change (at version b02b198226fc0f683648b3c91dba683cdf6e4c20) is now ready to be sponsored by a Committer.
Going to push as commit b895d7cf9fe0370a919e7092e40ac3458d91e95e.
Since your change was applied there have been 135 commits pushed to the master branch:
- 59c4649be37a387efaf100f368b3e9db06d44f3a: 8329959: Update DigestMD5Client.java - fix typo in javadoc string
- 4ffcf894b5937d6c6914b8f24caead87bd3e4228: 8339619: ProblemList runtime/cds/appcds/jvmti/dumpingWithAgent/DumpingWithJavaAgent.java
- 042053c3a82e9fbd4c6866efe872c1c92714e6e7: 8003887: File.getCanonicalFile() does not resolve symlinks on MS Windows
- b389bb456726184e4691777b1bb02d4b8a8a3f97: 8339540: Unify include requirements for PlatformMonitor/Mutex constructors/destructors
- ab656c3aab8157ed8e70bc126881cbadc825de93: 8339579: ZGC: Race results in only one of two remembered sets being cleared
- a505a1dda3bc6975bb11f390543b38618ddf2626: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation
- 6be927260a84b1d7542167e526ff41f7dc26cab0: 8338591: Improve performance of MemorySegment::copy
- cb9f5c5791d17afbf72f7debe8013b77e45b3b56: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo
- 340e131d616bd81ccd0bdc3817aead0284014cac: 8338971: IGV: Add incrementally inlined method name to phase name
- 2305d18e8d53dbbf341b580b60f9ed21f408bff1: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
- ... and 125 more: https://git.openjdk.org/jdk/compare/5671f836039ef1683e3e9ce5b7cf0fa2f1860e2d...master
Your commit was automatically rebased without conflicts.
@TheRealMDoerr @suchismith1993 Pushed as commit b895d7cf9fe0370a919e7092e40ac3458d91e95e.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.