jdk
jdk copied to clipboard
openjdk
8333664: Decouple command line parsing and package building in jpackage
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8333664: Decouple command line parsing and package building in jpackage (Enhancement - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19668/head:pull/19668
$ git checkout pull/19668
Update a local copy of the PR:
$ git checkout pull/19668
$ git pull https://git.openjdk.org/jdk.git pull/19668/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19668
View PR using the GUI difftool:
$ git pr show -t 19668
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19668.diff
:wave: Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@alexeysemenyukoracle This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8333664: Decouple command line parsing and package building in jpackage
Reviewed-by: almatvee
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 117 new commits pushed to the master branch:
- 76570c627db527f856f2394fb9ead02939eca621: 8357149: Test runtime/cds/appcds/aotCode/AOTCodeFlags.java is broken after JDK-8354887
- 10258dc56eb7d5d99ca8ed2579e871de91c74769: 8356811: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee: part 4
- 3dd34517000e4ce1a21619922c62c025f98aad44: 8357075: Remove leftover COMPAT locale data tests
- ... and 114 more: https://git.openjdk.org/jdk/compare/436960308cebe020549fcdbb4bcb12c90ce7aeb8...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
core-libs
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@alexeysemenyukoracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout JDK-8333664
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
⚠️ @alexeysemenyukoracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).
@alexeysemenyukoracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@alexeysemenyukoracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@alexeysemenyukoracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@alexeysemenyukoracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@alexeysemenyukoracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@alexeysemenyukoracle This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@alexeysemenyukoracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@alexeysemenyukoracle This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
Webrevs
- 04: Full - Incremental (8447a3e7)
- 03: Full (011eb710)
- 02: Full - Incremental (30e2a722)
- 01: Full (b7865ff0)
- 00: Full (9776f496)
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
Going to push as commit 21c1282207614e57138b37a7adca4ccf11cf5bef.
Since your change was applied there have been 174 commits pushed to the master branch:
- b63ec0ab584cb941b44a39b6ff130224ed444b60: 8356945: jdk/jfr/event/os/TestProcessStart failed on Windows Subsystem for Linux
- a07150af1139b262513a25f4fdd32173af95ff4f: 8357376: Disable syntax highlighting for JDK API docs
- a175767ccfb3dbcc04d1ba97f9fb2f57dc5ab5cf: 8357018: Guidance for ParallelRefProcEnabled is wrong in the man pages
- ... and 171 more: https://git.openjdk.org/jdk/compare/436960308cebe020549fcdbb4bcb12c90ce7aeb8...master
Your commit was automatically rebased without conflicts.
@alexeysemenyukoracle Pushed as commit 21c1282207614e57138b37a7adca4ccf11cf5bef.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.