jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8313562: hsperfdata should export module path and "launcher" metadata

Open larry-cable opened this issue 1 year ago • 6 comments

hsperfdata should expose module metadata if available.

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8313562: hsperfdata should export module path and "launcher" metadata

Issue

  • JDK-8313562: hsperfdata should export module path and "launcher" metadata (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19287/head:pull/19287
$ git checkout pull/19287

Update a local copy of the PR:
$ git checkout pull/19287
$ git pull https://git.openjdk.org/jdk.git pull/19287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19287

View PR using the GUI difftool:
$ git pr show -t 19287

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19287.diff

Webrev

Link to Webrev Comment

larry-cable avatar May 17 '24 18:05 larry-cable

/integrate

larry-cable avatar May 17 '24 18:05 larry-cable

:wave: Welcome back larry-cable! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 17 '24 18:05 bridgekeeper[bot]

@larry-cable This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313562: hsperfdata should export module path and "launcher" metadata

Reviewed-by: dholmes, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

  • 9ed8629e5d5e7b811c354cc1daf1ce5429eb184e: 8333801: Typos in @code references of BufferedImage and JTableHeader
  • 0d3a3771c3777d3dd1fec8dc8faed5fd02b06830: 8333887: ubsan: unsafe.cpp:247:13: runtime error: store to null pointer of type 'volatile int'
  • 9d8439c10780c3a0169c2675955a0506518f44fb: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
  • f5213671f7b636b32bb93c78e43696a61cd69bae: 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported cputime less than expected"
  • f8c657f6716c0de747be16814b55c3886bedf2d2: 8334123: log the opening of Type 1 fonts
  • 57b6481449612529615484a313d8b85ccf23e287: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero
  • 5528ad74902fa4f4ec621d70e7e7d85f4ac1d780: 8334179: VMATreeTest.TestConsistencyWithSimpleTracker_vm runs 50+ seconds
  • 5d2a19def154b81c8ebada5594e080fe76c5ffee: 8333684: C2 SuperWord: multiple smaller refactorings in preparation for JDK-8332163
  • 301bd7085654328f941c462bc786e995051d1a9c: 8311110: multichar warning in WinAccessBridge.cpp
  • 238162a3b8ce307659420661903a7f8ac1f06979: 8322064: Remove expired flags in JDK 24
  • ... and 123 more: https://git.openjdk.org/jdk/compare/244f6ac222fa98fba4fb99bf5bccd36e3e6c5de1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @kevinjwalls) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar May 17 '24 18:05 openjdk[bot]

@larry-cable This pull request has not yet been marked as ready for integration.

openjdk[bot] avatar May 17 '24 18:05 openjdk[bot]

@larry-cable The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 17 '24 18:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 17 '24 18:05 mlbridge[bot]

happy to do so although since their counterparts are listed in System::getProperties javadoc I assumed that the java namespace was sufficient.

  • Larry

On 5/19/24 6:27 PM, David Holmes wrote:

@.**** commented on this pull request.

In src/hotspot/share/runtime/statSampler.cpp https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*discussion_r1606153336__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKpGKpTb0Q$:

  • add_property_constant(JAVA_PROPERTY, "jdk.module.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.upgrade.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.main", CHECK);

These are not "java" properties - do we need to add a "jdk" namespace?

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*pullrequestreview-2065206278__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoDdBf2XA$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67UX7E7U7AU4SIHC4NTZDFGR5AVCNFSM6AAAAABH4SJC22VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRVGIYDMMRXHA__;!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoAsCXxPg$. You are receiving this because you were mentioned.Message ID: @.***>

--------------VXlZDC786aXcbpQh93JFAVU8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

happy to do so although since their counterparts are listed in System::getProperties javadoc I assumed that the java namespace
was sufficient.

- Larry

On 5/19/24 6:27 PM, David Holmes wrote:
  ***@***.***</b> commented on this pull request.</p>
  <hr>
  <p>In <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*discussion_r1606153336__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKpGKpTb0Q$" moz-do-not-send="true">src/hotspot/share/runtime/statSampler.cpp</a>:</p>
  <pre style="color:#555">&gt; +
  • add_property_constant(JAVA_PROPERTY, "jdk.module.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.upgrade.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.main", CHECK);

    These are not "java" properties - do we need to add a "jdk" namespace?

    —
    Reply to this email directly, view it on GitHub, or unsubscribe.
    You are receiving this because you were mentioned.Message ID: <openjdk/jdk/pull/19287/review/2065206278@github.com>

{ @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/openjdk/jdk/pull/19287#pullrequestreview-2065206278", "url": "https://github.com/openjdk/jdk/pull/19287#pullrequestreview-2065206278", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]


--------------VXlZDC786aXcbpQh93JFAVU8--

larry-cable avatar May 20 '24 14:05 larry-cable

I also note that "jdk.debug property is a JAVA_PROPERTY, so not sure what to do here in the presence of this potential "precident"?

  • Larry

On 5/19/24 6:27 PM, David Holmes wrote:

@.**** commented on this pull request.

In src/hotspot/share/runtime/statSampler.cpp https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*discussion_r1606153336__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKpGKpTb0Q$:

  • add_property_constant(JAVA_PROPERTY, "jdk.module.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.upgrade.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.main", CHECK);

These are not "java" properties - do we need to add a "jdk" namespace?

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*pullrequestreview-2065206278__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoDdBf2XA$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67UX7E7U7AU4SIHC4NTZDFGR5AVCNFSM6AAAAABH4SJC22VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRVGIYDMMRXHA__;!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoAsCXxPg$. You are receiving this because you were mentioned.Message ID: @.***>

--------------7k0FeE9fQIGLR7ZxNRvoacUT Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

I also note that "jdk.debug property is a JAVA_PROPERTY, so not sure what to do here in the presence of this potential "precident"?

- Larry

On 5/19/24 6:27 PM, David Holmes wrote:
  ***@***.***</b> commented on this pull request.</p>
  <hr>
  <p>In <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*discussion_r1606153336__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKpGKpTb0Q$" moz-do-not-send="true">src/hotspot/share/runtime/statSampler.cpp</a>:</p>
  <pre style="color:#555">&gt; +
  • add_property_constant(JAVA_PROPERTY, "jdk.module.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.upgrade.path", CHECK);
  • add_property_constant(JAVA_PROPERTY, "jdk.module.main", CHECK);

    These are not "java" properties - do we need to add a "jdk" namespace?

    —
    Reply to this email directly, view it on GitHub, or unsubscribe.
    You are receiving this because you were mentioned.Message ID: <openjdk/jdk/pull/19287/review/2065206278@github.com>

{ @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/openjdk/jdk/pull/19287#pullrequestreview-2065206278", "url": "https://github.com/openjdk/jdk/pull/19287#pullrequestreview-2065206278", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]


--------------7k0FeE9fQIGLR7ZxNRvoacUT--

larry-cable avatar May 20 '24 17:05 larry-cable

/integrate

larry-cable avatar Jun 04 '24 17:06 larry-cable

@larry-cable Your change (at version cd1d3f300773988a5522419aff3f2f6959fefc22) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Jun 04 '24 17:06 openjdk[bot]

/integrate

larry-cable avatar Jun 13 '24 16:06 larry-cable

@larry-cable Your change (at version 17389700da0a57ab613681a937bfacdbaed15e5a) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Jun 13 '24 16:06 openjdk[bot]

/sponsor

kevinjwalls avatar Jun 13 '24 16:06 kevinjwalls

Going to push as commit 814cf8793097ef03a15068589c22a59ac5966430. Since your change was applied there have been 133 commits pushed to the master branch:

  • 9ed8629e5d5e7b811c354cc1daf1ce5429eb184e: 8333801: Typos in @code references of BufferedImage and JTableHeader
  • 0d3a3771c3777d3dd1fec8dc8faed5fd02b06830: 8333887: ubsan: unsafe.cpp:247:13: runtime error: store to null pointer of type 'volatile int'
  • 9d8439c10780c3a0169c2675955a0506518f44fb: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
  • f5213671f7b636b32bb93c78e43696a61cd69bae: 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported cputime less than expected"
  • f8c657f6716c0de747be16814b55c3886bedf2d2: 8334123: log the opening of Type 1 fonts
  • 57b6481449612529615484a313d8b85ccf23e287: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero
  • 5528ad74902fa4f4ec621d70e7e7d85f4ac1d780: 8334179: VMATreeTest.TestConsistencyWithSimpleTracker_vm runs 50+ seconds
  • 5d2a19def154b81c8ebada5594e080fe76c5ffee: 8333684: C2 SuperWord: multiple smaller refactorings in preparation for JDK-8332163
  • 301bd7085654328f941c462bc786e995051d1a9c: 8311110: multichar warning in WinAccessBridge.cpp
  • 238162a3b8ce307659420661903a7f8ac1f06979: 8322064: Remove expired flags in JDK 24
  • ... and 123 more: https://git.openjdk.org/jdk/compare/244f6ac222fa98fba4fb99bf5bccd36e3e6c5de1...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jun 13 '24 16:06 openjdk[bot]

@kevinjwalls @larry-cable Pushed as commit 814cf8793097ef03a15068589c22a59ac5966430.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jun 13 '24 16:06 openjdk[bot]