jdk
jdk copied to clipboard
openjdk
8332416: Add more font selection options to Font2DTest
Enhance Font2DTest as follows
- Add main menu Radio Button options so that you select the font to use as either
- (1) Font Family + Style (as now)
- (2) Font Family + Menu of all members of the Family, replacing the Style
- (3) List of all fontnames - which can still be adjusted by Style if you want. The default is (1) so nothing looks different except that I updated the UI to use Nimbus instead of Metal.
There's new code to gather these ways of referencing the fonts. Also changes were needed for the "Save/Load" options to include the new UI state and font settings.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8332416: Add more font selection options to Font2DTest (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19273/head:pull/19273
$ git checkout pull/19273
Update a local copy of the PR:
$ git checkout pull/19273
$ git pull https://git.openjdk.org/jdk.git pull/19273/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19273
View PR using the GUI difftool:
$ git pr show -t 19273
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19273.diff
Webrev
:wave: Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@prrace This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8332416: Add more font selection options to Font2DTest
Reviewed-by: tr, honkar
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 84 new commits pushed to the master branch:
- da3001daf79bf943d6194d9fd60250d519b9680d: 8331975: Enable case-insensitive check in ccache and keytab entry lookup
- 424eb60dedb332237b8ec97e9da6bd95442c0083: 8331683: Clean up GetCarrierThread
- 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
- f8a3e4e428f7d3e62177bdf148fe25e22d3ee2bf: 8328998: Encoding support for Intel APX extended general-purpose registers
- ddd73b458355bffeaa8e0e5017c27d6c6af2dc94: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
- 0a9d1f8c89e946d99f01549515f6044e53992168: 8332749: Broken link in MemorySegment.Scope.html
- c9a7b9772d96d9a4825d9da2aacc277534282860: 8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs
- 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9: 8332340: Add JavacBench as a test case for CDS
- 417d174aa1b7bd3b5755e5f2352d9bbe6ce6f183: 8331348: Some incremental builds deposit files in the make directory
- 303ac9f270f567d821d156f3a9d4f4c070f43f95: 8332671: Logging for pretouching thread stacks shows wrong memory range
- ... and 74 more: https://git.openjdk.org/jdk/compare/da9c23ace9bdf398d811a88ed137217dd3167231...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@prrace The following label will be automatically applied to this pull request:
client
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
BTW, it is probably obvious , but maybe 50% of "reviewing" this will be pulling it down and building it locally and trying it out. Very hard to review by code changes alone.
I have an observation, not sure if it's supposed to be this way or not. The Style/SubFamily type selected in other mentioned type (Select font using Family and Style/SubFamily/Full Name) has an impact on each other type. For example, if we select bold as Style and then in type 2 we select SubFamily as .plain then it'll be bold+.plain right? Or its supposed to be only .plain in type 2?
Probably not. I was OK with "Style" being applied to "FontName" because we show the "Style" menu alongside font name. Ordinarily you would use PLAIN but being able to select BOLD then allows you to test what happens in our implementation when you say "Arial Italic with style Bold please" .. we figure out that you want "Arial Bold Italic".
But if we are using Family + SubFamily you don't see the "Style" menu, but I think you are right that it probably remembers the last selected style and applies it and then the substitution will happen as described above, but the UI doesn't show this. To avoid this I think I can just reset "Style" to "PLAIN" whenever switching the UI to use SubFamily.
I think I can just reset "Style" to "PLAIN" whenever switching the UI to use SubFamily.
It was a bit more than that, but I think it is behaving sensibly now. Please take another look.
I think I can just reset "Style" to "PLAIN" whenever switching the UI to use SubFamily.
It was a bit more than that, but I think it is behaving sensibly now. Please take another look.
Yeah, it's fine now. The reset is happening and the selections are independent of its type.
To avoid this I think I can just reset "Style" to "PLAIN" whenever switching the UI to use SubFamily.
Changes looks good after the following fix. Save and Load option works as expected.
Going to push as commit 97ee2ffb89257a37a178b70c8fee96a1d831deb6.
Since your change was applied there have been 105 commits pushed to the master branch:
- 985b9ce79a2d620a8b8675d1ae6c9730d72a757f: 8330694: Rename 'HeapRegion' to 'G1HeapRegion'
- 05f13e75ee4407ba9213c69b33c6032aa87c9e95: 8329667: [macos] Issue with JTree related fix for JDK-8317771
- 7bf1989f59695c3d08b4bd116fb4c022cf9661f4: 8320575: generic type information lost on mandated parameters of record's compact constructors
- 253508b03a3de4dab00ed7fb57e9f345d8aed1a4: 8332303: Better JMX interoperability with older JDKs, after removing Subject Delegation
- ebc520e83f503eeb4e5af6d5aef62df9227af4f7: 8332841: GenShen: Pull shared members from control thread into common base class
- 236432dbdb9bab4aece54c2fea08f055e5dbf97e: 8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook
- b3b33667ad3bdb7be868fb165a1ea53054947cd0: 8332631: Update nsk.share.jpda.BindServer to don't use finalization
- f66a58661459bf64212ec332540c12d5d691270f: 8332641: Update nsk.share.jpda.Jdb to don't use finalization
- cd3e4c03661f770ebeefcd3637d56589243ac0a9: 8326734: text-decoration applied to lost when mixed with or
- c2cca2ab443ff87f689810b747985adfdbfbe54a: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC
- ... and 95 more: https://git.openjdk.org/jdk/compare/da9c23ace9bdf398d811a88ed137217dd3167231...master
Your commit was automatically rebased without conflicts.
@prrace Pushed as commit 97ee2ffb89257a37a178b70c8fee96a1d831deb6.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.