jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8332226: "Invalid package name:" from source launcher

Open sormuras opened this issue 1 year ago • 4 comments

Please review this change excluding directory paths with invalid elements when computing the packages of a module in source-launch mode.

Note that this inital iteration of the change only fixes the in-memory computation of package names - the behaviour of the associated module reader implementation is untouched for the time being. This introduces a difference in the set of resources being readable at runtime. For example, see the modified test case: the new and invalid .bar directory doesn't show up in the contents of the module - but it is reported by the module reader's list() method.

Note additionally, that above's behaviour is also observed for compiled and exploded modules. Meaning, that with this change being applied, the source mode and compiled mode of the launcher are in line.

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8332226: "Invalid package name:" from source launcher (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19245/head:pull/19245
$ git checkout pull/19245

Update a local copy of the PR:
$ git checkout pull/19245
$ git pull https://git.openjdk.org/jdk.git pull/19245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19245

View PR using the GUI difftool:
$ git pr show -t 19245

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19245.diff

Webrev

Link to Webrev Comment

sormuras avatar May 15 '24 07:05 sormuras

:wave: Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 15 '24 07:05 bridgekeeper[bot]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332226: "Invalid package name:" from source launcher

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • 239c1b33b47de43369673f33d9449e1904477ce0: 8332807: Parallel: Make some APIs in ParMarkBitMap private
  • 9b61a7608efff13fc3685488f3f54a810ec0ac22: 8332615: RISC-V: Support vector unsigned comparison instructions for machines with RVV
  • a71b40478510db3c69696df608fd1b32f41c57f3: 8331398: G1: G1HeapRegionPrinter reclamation events should print the original region type
  • af056c1676dab3b0b35666a8259db60f9bbf824e: 8332106: VerifyError when using switch pattern in this(...) or super(...)
  • da3001daf79bf943d6194d9fd60250d519b9680d: 8331975: Enable case-insensitive check in ccache and keytab entry lookup
  • 424eb60dedb332237b8ec97e9da6bd95442c0083: 8331683: Clean up GetCarrierThread
  • 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • f8a3e4e428f7d3e62177bdf148fe25e22d3ee2bf: 8328998: Encoding support for Intel APX extended general-purpose registers
  • ddd73b458355bffeaa8e0e5017c27d6c6af2dc94: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
  • 0a9d1f8c89e946d99f01549515f6044e53992168: 8332749: Broken link in MemorySegment.Scope.html
  • ... and 110 more: https://git.openjdk.org/jdk/compare/d04ac14bdbab4187d0be98b8471f90be8a14f649...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 15 '24 07:05 openjdk[bot]

@sormuras The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 15 '24 07:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 15 '24 07:05 mlbridge[bot]

/integrate

sormuras avatar May 24 '24 12:05 sormuras

Going to push as commit f16265d69b09640b972b7494ad57158dbdc426bb. Since your change was applied there have been 121 commits pushed to the master branch:

  • 5a2ba952b120394d7cc0d0890619780c1c27a078: 8325841: Remove unused references to vmSymbols.hpp
  • 239c1b33b47de43369673f33d9449e1904477ce0: 8332807: Parallel: Make some APIs in ParMarkBitMap private
  • 9b61a7608efff13fc3685488f3f54a810ec0ac22: 8332615: RISC-V: Support vector unsigned comparison instructions for machines with RVV
  • a71b40478510db3c69696df608fd1b32f41c57f3: 8331398: G1: G1HeapRegionPrinter reclamation events should print the original region type
  • af056c1676dab3b0b35666a8259db60f9bbf824e: 8332106: VerifyError when using switch pattern in this(...) or super(...)
  • da3001daf79bf943d6194d9fd60250d519b9680d: 8331975: Enable case-insensitive check in ccache and keytab entry lookup
  • 424eb60dedb332237b8ec97e9da6bd95442c0083: 8331683: Clean up GetCarrierThread
  • 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • f8a3e4e428f7d3e62177bdf148fe25e22d3ee2bf: 8328998: Encoding support for Intel APX extended general-purpose registers
  • ddd73b458355bffeaa8e0e5017c27d6c6af2dc94: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
  • ... and 111 more: https://git.openjdk.org/jdk/compare/d04ac14bdbab4187d0be98b8471f90be8a14f649...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 24 '24 12:05 openjdk[bot]

@sormuras Pushed as commit f16265d69b09640b972b7494ad57158dbdc426bb.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 24 '24 12:05 openjdk[bot]