8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER

[jaikiran]

Can I please get a review of this doc-only change which clarifies the value type for the java.net.SocketOptions.SO_LINGER option?

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19243/head:pull/19243
$ git checkout pull/19243

Update a local copy of the PR:
$ git checkout pull/19243
$ git pull https://git.openjdk.org/jdk.git pull/19243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19243

View PR using the GUI difftool:
$ git pr show -t 19243

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19243.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER

Reviewed-by: alanb, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

• 52eda79522a5bd71b527e5946b654a331b021473: 8332538: Switch off JIT memory limit check for TestAlignVectorFuzzer.java
• d999b81e7110751be402012e1ed41b3256f5895e: 8331572: Allow using OopMapCache outside of STW GC phases
• 8291c94bcdbb01beddc94f290f2749841404cc0c: 8331224: ClassCastException in ObjectInputStream hides ClassNotFoundException
• 42e3c842ae2684265c794868fc76eb0ff2dea3d9: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory
• 5cf8288b8071bdcf0c923dd7ba36f91bc7594ef3: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
• ae9ad862ee54e119553efec919f1061dca36b954: 8331934: [s390x] Add support for primitive array C1 clone intrinsic
• 3479b46c5bea3afd92b6ab4acd2fe7f274df38aa: 8332595: Serial: Remove unused TenuredGeneration::should_collect
• 9bfae8891e6efa58c557bd6dac61de111a16f71e: 8332297: annotation processor that generates records sometimes fails due to NPE in javac
• 4e169d1ed7501d1de8fd4ea326f84b6c1a34270d: 8332401: G1: TestFromCardCacheIndex.java with -XX:GCCardSizeInBytes=128 triggers underflow assertion
• 7ffc9997bd4a93cefe30f672a5f0e9c49215d2c7: 8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct
• ... and 73 more: https://git.openjdk.org/jdk/compare/5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (2f391f08)
• 02: Full - Incremental (239cb50e)
• 01: Full - Incremental (c9461808)
• 00: Full (facb2af8)

[AlanBateman]

/csr

[openjdk[bot]]

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@jaikiran please create a CSR request for issue JDK-8329825 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[jaikiran]

Thank you Alan for the review. I've opened a CSR https://bugs.openjdk.org/browse/JDK-8332512 for this change.

[jaikiran]

Thank you Daniel and Alan for the reviews, both here and on the CSR. I'll go ahead and integrate this now.

[jaikiran]

/integrate

[openjdk[bot]]

Going to push as commit 5f804b2ec12627b593353ceeab881187b0bb5cd6. Since your change was applied there have been 83 commits pushed to the master branch:

• 52eda79522a5bd71b527e5946b654a331b021473: 8332538: Switch off JIT memory limit check for TestAlignVectorFuzzer.java
• d999b81e7110751be402012e1ed41b3256f5895e: 8331572: Allow using OopMapCache outside of STW GC phases
• 8291c94bcdbb01beddc94f290f2749841404cc0c: 8331224: ClassCastException in ObjectInputStream hides ClassNotFoundException
• 42e3c842ae2684265c794868fc76eb0ff2dea3d9: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory
• 5cf8288b8071bdcf0c923dd7ba36f91bc7594ef3: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API)
• ae9ad862ee54e119553efec919f1061dca36b954: 8331934: [s390x] Add support for primitive array C1 clone intrinsic
• 3479b46c5bea3afd92b6ab4acd2fe7f274df38aa: 8332595: Serial: Remove unused TenuredGeneration::should_collect
• 9bfae8891e6efa58c557bd6dac61de111a16f71e: 8332297: annotation processor that generates records sometimes fails due to NPE in javac
• 4e169d1ed7501d1de8fd4ea326f84b6c1a34270d: 8332401: G1: TestFromCardCacheIndex.java with -XX:GCCardSizeInBytes=128 triggers underflow assertion
• 7ffc9997bd4a93cefe30f672a5f0e9c49215d2c7: 8332498: [aarch64, x86] improving OpToAssembly output for partialSubtypeCheckConstSuper Instruct
• ... and 73 more: https://git.openjdk.org/jdk/compare/5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@jaikiran Pushed as commit 5f804b2ec12627b593353ceeab881187b0bb5cd6.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.