jdk
jdk copied to clipboard
8301464: Code in GenFullCP is still disabled after JDK-8079697 was fixed
Code in GenFullCP is still disabled after JDK-8079697 was fixed note:I have not found any relevant information on why ClassWriter.COMPUTE_FRAMES is disabled in JDK-8079697.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8301464: Code in GenFullCP is still disabled after JDK-8079697 was fixed (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19228/head:pull/19228
$ git checkout pull/19228
Update a local copy of the PR:
$ git checkout pull/19228
$ git pull https://git.openjdk.org/jdk.git pull/19228/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19228
View PR using the GUI difftool:
$ git pr show -t 19228
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19228.diff
Webrev
:wave: Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@xiaotaonan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.
Applicable Labels
buildclientcompilercore-libsgraalhotspothotspot-compilerhotspot-gchotspot-jfrhotspot-runtimei18nide-supportjavadocjdkjmxkullanetniosecurityserviceabilityshenandoah
/label hotspot-gc
@xiaotaonan
The hotspot-gc label was successfully added.
/label hotspot
@xiaotaonan
The hotspot label was successfully added.
This is not related to GC code, could you remove the hotspot-gc label you added?
/unlabel hotspot-gc
@xiaotaonan Unknown command unlabel - for a list of valid commands use /help.
/help
@xiaotaonan Available commands:
- approval - request for maintainer's approval
- approve - null
- author - sets an overriding author to be used in the commit when the PR is integrated
- backport - create a backport
- cc - add or remove an additional classification label
- clean - Mark the backport pull request as a clean backport
- contributor - adds or removes additional contributors for a PR
- covered - used when employer has signed the OCA
- csr - require a compatibility and specification request (CSR) for this pull request
- help - shows this text
- integrate - performs integration of the changes in the PR
- issue - edit the list of issues that this PR solves
- jep - require a JDK Enhancement Proposal (JEP) for this pull request
- label - add or remove an additional classification label
- open - Set the pull request state to "open"
- reviewer - manage additional reviewers for a PR
- reviewers - set the number of additional required reviewers for this PR
- signed - used after signing the OCA
- solves - edit the list of issues that this PR solves
- sponsor - performs integration of a PR that is authored by a non-committer
- summary - updates the summary in the commit message
- test - used to run tests
/label hotspot-gc
@xiaotaonan The hotspot-gc label was already applied.
/label -remove hotspot-gc
@xiaotaonan
The label remove is not a valid label.
These labels are valid:
graalserviceabilityhotspothotspot-compileride-supportkullai18nshenandoahjdkjavadocsecurityhotspot-runtimejmxbuildnioclientcore-libscompilernethotspot-gchotspot-jfr
/label remove hotspot-gc
@xiaotaonan
The hotspot-gc label was successfully removed.
@stefank @mdinacci @hns @landonf
@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@xiaotaonan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.