jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8322008: Exclude some CDS tests from running with -Xshare:off

Open calvinccheung opened this issue 1 year ago • 7 comments

Some CDS tests throws a SkippedException when -Xshare:off is specified. This change adds a hotspot_runtime_non_cds_mode test group for excluding those tests.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8322008: Exclude some CDS tests from running with -Xshare:off (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19221/head:pull/19221
$ git checkout pull/19221

Update a local copy of the PR:
$ git checkout pull/19221
$ git pull https://git.openjdk.org/jdk.git pull/19221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19221

View PR using the GUI difftool:
$ git pr show -t 19221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19221.diff

Webrev

Link to Webrev Comment

calvinccheung avatar May 13 '24 18:05 calvinccheung

/label add hotspot-runtime

calvinccheung avatar May 13 '24 18:05 calvinccheung

:wave: Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 13 '24 18:05 bridgekeeper[bot]

/label add hotspot-test

calvinccheung avatar May 13 '24 18:05 calvinccheung

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322008: Exclude some CDS tests from running with -Xshare:off

Reviewed-by: lmesnik, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • e91492ab4333c61f39b50eb428fa932131a5b908: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 95a601316de06b4b0fbf6e3c7777be5d2a1ca978: 8332042: Move MEMFLAGS to its own include file
  • 5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e: 8331858: [nmt] VM.native_memory statistics should work in summary mode
  • 4ba74475d44831c1fe49359458163cd1567e9619: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
  • 7ce4a13c0a891e606480e138f4025ffa328a18b3: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
  • ea5eb74a65f20ce28fa0a94ea851915d4a6f83da: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
  • beea5305b071820e2b128a55c5ca384caf470fdd: 8331907: BigInteger and BigDecimal should use optimized division
  • 440782e0160f867f08afbec0abf48d557a522c72: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
  • 5ded8da676d62158d0011086d7f80ff2c9096e13: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
  • 7c2c24fc0511b36132952c96be46eea5904a53c5: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • ... and 34 more: https://git.openjdk.org/jdk/compare/a643d6c7ac8a7bc0d3a288c1ef3f07876cf70590...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 13 '24 18:05 openjdk[bot]

@calvinccheung The hotspot-runtime label was successfully added.

openjdk[bot] avatar May 13 '24 18:05 openjdk[bot]

@calvinccheung The label hotspot-test is not a valid label. These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

openjdk[bot] avatar May 13 '24 18:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 13 '24 18:05 mlbridge[bot]

Thanks @lmesnik, @iklam for the review.

/integrate

calvinccheung avatar May 14 '24 19:05 calvinccheung

Going to push as commit 4d32c607a4b496bf2bb09e54167ecbbab5569a0c. Since your change was applied there have been 44 commits pushed to the master branch:

  • e91492ab4333c61f39b50eb428fa932131a5b908: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 95a601316de06b4b0fbf6e3c7777be5d2a1ca978: 8332042: Move MEMFLAGS to its own include file
  • 5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e: 8331858: [nmt] VM.native_memory statistics should work in summary mode
  • 4ba74475d44831c1fe49359458163cd1567e9619: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
  • 7ce4a13c0a891e606480e138f4025ffa328a18b3: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
  • ea5eb74a65f20ce28fa0a94ea851915d4a6f83da: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
  • beea5305b071820e2b128a55c5ca384caf470fdd: 8331907: BigInteger and BigDecimal should use optimized division
  • 440782e0160f867f08afbec0abf48d557a522c72: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
  • 5ded8da676d62158d0011086d7f80ff2c9096e13: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
  • 7c2c24fc0511b36132952c96be46eea5904a53c5: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • ... and 34 more: https://git.openjdk.org/jdk/compare/a643d6c7ac8a7bc0d3a288c1ef3f07876cf70590...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 14 '24 19:05 openjdk[bot]

@calvinccheung Pushed as commit 4d32c607a4b496bf2bb09e54167ecbbab5569a0c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 14 '24 19:05 openjdk[bot]