jdk
jdk copied to clipboard
openjdk
8331858: [nmt] VM.native_memory statistics should work in summary mode
Hi all,
This PR addresses 8331858 enabling the "statistics" sub-option for jcmd VM.native_memory.
Since 8256844, preinit state gets printed under "statistics" and this is also relevant for the summary state.
Testing:
- [x] Added test case passes.
Thanks!
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8331858: [nmt] VM.native_memory statistics should work in summary mode (Enhancement - P4)
Reviewers
- Thomas Stuefe (@tstuefe - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19179/head:pull/19179
$ git checkout pull/19179
Update a local copy of the PR:
$ git checkout pull/19179
$ git pull https://git.openjdk.org/jdk.git pull/19179/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19179
View PR using the GUI difftool:
$ git pr show -t 19179
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19179.diff
Webrev
:wave: Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@SoniaZaldana This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8331858: [nmt] VM.native_memory statistics should work in summary mode
Reviewed-by: stuefe, jsjolen
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 74 new commits pushed to the master branch:
- 4ba74475d44831c1fe49359458163cd1567e9619: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
- 7ce4a13c0a891e606480e138f4025ffa328a18b3: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
- ea5eb74a65f20ce28fa0a94ea851915d4a6f83da: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
- beea5305b071820e2b128a55c5ca384caf470fdd: 8331907: BigInteger and BigDecimal should use optimized division
- 440782e0160f867f08afbec0abf48d557a522c72: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
- 5ded8da676d62158d0011086d7f80ff2c9096e13: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
- 7c2c24fc0511b36132952c96be46eea5904a53c5: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
- ff4bf1cf9f18547cff8f484433c3c55b4c288aaa: 8332102: Add
@sinceto package-info ofjdk.security.jarsigner - abf54bb1e6da6d7bc432b3e9bb3ff164a895bd3e: 8332100: Add missing
@sinceto KeyValue::EC_TYPE injava.xml.crypto - 1484153c1a092cefc20270b35aa1e508280843a4: 8332080: Update troff man page for javadoc
- ... and 64 more: https://git.openjdk.org/jdk/compare/524aaad98317b1a50453e5a9a44922f481fb3b1e...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @jdksjolen) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@SoniaZaldana The following label will be automatically applied to this pull request:
hotspot-runtime
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@SoniaZaldana Your change (at version 8df83d1455086cd908d493ed97d5cd2e35599aa3) is now ready to be sponsored by a Committer.
Going to push as commit 5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e.
Since your change was applied there have been 74 commits pushed to the master branch:
- 4ba74475d44831c1fe49359458163cd1567e9619: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
- 7ce4a13c0a891e606480e138f4025ffa328a18b3: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
- ea5eb74a65f20ce28fa0a94ea851915d4a6f83da: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
- beea5305b071820e2b128a55c5ca384caf470fdd: 8331907: BigInteger and BigDecimal should use optimized division
- 440782e0160f867f08afbec0abf48d557a522c72: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
- 5ded8da676d62158d0011086d7f80ff2c9096e13: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
- 7c2c24fc0511b36132952c96be46eea5904a53c5: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
- ff4bf1cf9f18547cff8f484433c3c55b4c288aaa: 8332102: Add
@sinceto package-info ofjdk.security.jarsigner - abf54bb1e6da6d7bc432b3e9bb3ff164a895bd3e: 8332100: Add missing
@sinceto KeyValue::EC_TYPE injava.xml.crypto - 1484153c1a092cefc20270b35aa1e508280843a4: 8332080: Update troff man page for javadoc
- ... and 64 more: https://git.openjdk.org/jdk/compare/524aaad98317b1a50453e5a9a44922f481fb3b1e...master
Your commit was automatically rebased without conflicts.
@tstuefe @SoniaZaldana Pushed as commit 5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.