jdk
jdk copied to clipboard
openjdk
8331876: JFR: Move file read and write events to java.base
Hi,
Could I have a review of a change that moves the jdk.FileRead and jdk.FileWrite events to java.base to remove the use of the ASM instrumentation.
Testing: jdk/jdk/jfr
Thanks Erik
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8331876: JFR: Move file read and write events to java.base (Sub-task - P2)
Reviewers
- Markus Grönlund (@mgronlun - Reviewer) ⚠️ Review applies to 0802c684
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19129/head:pull/19129
$ git checkout pull/19129
Update a local copy of the PR:
$ git checkout pull/19129
$ git pull https://git.openjdk.org/jdk.git pull/19129/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19129
View PR using the GUI difftool:
$ git pr show -t 19129
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19129.diff
Webrev
:wave: Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@egahlin This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8331876: JFR: Move file read and write events to java.base
Reviewed-by: mgronlun, alanb
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 282 new commits pushed to the master branch:
- f608918df3f887277845db383cf07b0863bba615: 8332614: Type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull
- 1b04f6487c98899f738600fddfa726bab5167018: 8216984: Deprecate for removal Socket constructors to create UDP sockets
- 3cff588a3104aa5224e7236eb2c2bb5852de9202: 8332826: Make hashCode methods in ArraysSupport friendlier
- 2b4a4b7bd84806f997adc107abbd4351425e8d1d: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
- 286cc163fd4f8361a633dcb6494965020d02b506: 8327401: Some jtreg tests fail on Wayland without any tracking bug
- 579cf705ff74d1ebb56b605d9a7ca17d87c36d84: 8332597: Remove redundant methods from j.l.classfile.ClassReader API
- 57bfd0e393c58b01cb427a6fbee8ea541ae30efb: 8332065: Calling readLine(null...) or readPassword(null...) on System.console() hangs jshell
- 9a72068ef049886dada09e156118b1e9e8f80d11: 8332230: jshell throws AssertionError when processing annotations
- 66d9bfce2909c26ad094d5a38c4a9aaa176e8faa: 8332725: Binding patterns with inferred type have erroneous node in the AST
- 2ea365c94533a59865ab4c20ad8e1008072278da: 8333099: Missing check for is_LoadVector in StoreNode::Identity
- ... and 272 more: https://git.openjdk.org/jdk/compare/8d78e8cadcc06aea7179ec97d3bf8b7cee63b447...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@egahlin The following labels will be automatically applied to this pull request:
core-libshotspot-jfrniosecurity
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
Webrevs
- 06: Full - Incremental (87647f9d)
- 05: Full - Incremental (8a44b649)
- 04: Full - Incremental (c4c64774)
- 03: Full - Incremental (f2439ac3)
- 02: Full - Incremental (fc54e205)
- 01: Full - Incremental (9d02bf63)
- 00: Full (0802c684)
Going to push as commit 4a20691e9b0276e2dc5e7eb6a4d05393d6b4c99c.
Since your change was applied there have been 282 commits pushed to the master branch:
- f608918df3f887277845db383cf07b0863bba615: 8332614: Type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull
- 1b04f6487c98899f738600fddfa726bab5167018: 8216984: Deprecate for removal Socket constructors to create UDP sockets
- 3cff588a3104aa5224e7236eb2c2bb5852de9202: 8332826: Make hashCode methods in ArraysSupport friendlier
- 2b4a4b7bd84806f997adc107abbd4351425e8d1d: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
- 286cc163fd4f8361a633dcb6494965020d02b506: 8327401: Some jtreg tests fail on Wayland without any tracking bug
- 579cf705ff74d1ebb56b605d9a7ca17d87c36d84: 8332597: Remove redundant methods from j.l.classfile.ClassReader API
- 57bfd0e393c58b01cb427a6fbee8ea541ae30efb: 8332065: Calling readLine(null...) or readPassword(null...) on System.console() hangs jshell
- 9a72068ef049886dada09e156118b1e9e8f80d11: 8332230: jshell throws AssertionError when processing annotations
- 66d9bfce2909c26ad094d5a38c4a9aaa176e8faa: 8332725: Binding patterns with inferred type have erroneous node in the AST
- 2ea365c94533a59865ab4c20ad8e1008072278da: 8333099: Missing check for is_LoadVector in StoreNode::Identity
- ... and 272 more: https://git.openjdk.org/jdk/compare/8d78e8cadcc06aea7179ec97d3bf8b7cee63b447...master
Your commit was automatically rebased without conflicts.
@egahlin Pushed as commit 4a20691e9b0276e2dc5e7eb6a4d05393d6b4c99c.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.