jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8330205: Initial troff manpage generation for JDK 24

Open pavelrappo opened this issue 1 year ago • 9 comments

Please review this mechanical change to man pages. This PR should be integrated after https://github.com/openjdk/jdk/pull/18787.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8330205: Initial troff manpage generation for JDK 24 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19119/head:pull/19119
$ git checkout pull/19119

Update a local copy of the PR:
$ git checkout pull/19119
$ git pull https://git.openjdk.org/jdk.git pull/19119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19119

View PR using the GUI difftool:
$ git pr show -t 19119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19119.diff

Webrev

Link to Webrev Comment

pavelrappo avatar May 07 '24 11:05 pavelrappo

:wave: Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 07 '24 11:05 bridgekeeper[bot]

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330205: Initial troff manpage generation for JDK 24

Reviewed-by: darcy, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • d47a4e9f63a9414b90e09514bc26f6f7142ad49f: 8332008: Enable issuestitle check
  • 0bf728212fb4bce067076780aaa5b9341d7cdb6b: 8331231: containers/docker/TestContainerInfo.java fails
  • ffbdfffbc702253f32fa45dc1855b663c72074a6: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
  • c7d98df2ac509ebc8f4e801a0874a9497c54c602: 8329691: Support nonlikelyScript parent locale inheritance
  • aa4cddd4b8a6a12ba5d0360a721aebaabf362fff: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists
  • c4ff58b9bcfd08eae0623a648a837e08f25b3f9b: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed
  • aaa90b3005c85852971203ce6feb88e7091e167b: 8327476: Upgrade JLine to 3.26.1
  • 0a4eeeaa3c63585244be959386dd94882398e87f: 8331033: EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331
  • ad0b54d429fdbd806c09aa06bb42f1ed4a0297e8: 8314225: SIGSEGV in JavaThread::is_lock_owned
  • ac86f59e4f5382d5c3e8984532dd210611db7dcb: 8330532: Improve line-oriented text parsing in HotSpot
  • ... and 27 more: https://git.openjdk.org/jdk/compare/23a72a1f2f651d5e8e9a0eb1e75e2b44572a13da...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 07 '24 11:05 openjdk[bot]

@pavelrappo The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar May 07 '24 11:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 07 '24 11:05 mlbridge[bot]

This PR is standalone as opposed to dependent because the https://github.com/openjdk/jdk/pull/18787 dependency currently has a merge conflict, which complicates the required workflow.

This comment serves as a reminder to merge master into this PR once https://github.com/openjdk/jdk/pull/18787 has been integrated. If we don't do that, Skara will likely create a backport issue:

(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 23, a new backport will be created when this pr is integrated.)

pavelrappo avatar May 07 '24 12:05 pavelrappo

This PR is standalone as opposed to dependent because the #18787 dependency currently has a merge conflict, which complicates the required workflow.

This comment serves as a reminder to merge master into this PR once #18787 has been integrated. If we don't do that, Skara will likely create a backport issue:

(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 23, a new backport will be created when this pr is integrated.)

Thanks @pavelrappo. For as a small risk-reduction exercise, the fixVersion on the bug could also be changed to tbd, but if it is integrated after the main start-of-release PR it should be fine.

jddarcy avatar May 07 '24 20:05 jddarcy

Thanks for reviewing it Joe, I'm now delegating integration of this PR to @JesperIRL, you, or anyone who will be integrating https://github.com/openjdk/jdk/pull/18787.

pavelrappo avatar May 07 '24 22:05 pavelrappo

/integrate delegate

pavelrappo avatar May 07 '24 22:05 pavelrappo

@pavelrappo Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command.

openjdk[bot] avatar May 07 '24 22:05 openjdk[bot]

Withdrawing this, as a different approach is required.

pavelrappo avatar May 14 '24 21:05 pavelrappo