jdk
jdk copied to clipboard
openjdk
8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices (Enhancement - P4)
Reviewers
- Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 39e348b3
- Brian Burkhalter (@bplb - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19021/head:pull/19021
$ git checkout pull/19021
Update a local copy of the PR:
$ git checkout pull/19021
$ git pull https://git.openjdk.org/jdk.git pull/19021/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19021
View PR using the GUI difftool:
$ git pr show -t 19021
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19021.diff
Webrev
:wave: Welcome back txominpelu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@txominpelu This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
Reviewed-by: alanb, bpb
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 195 new commits pushed to the master branch:
- 7ce4a13c0a891e606480e138f4025ffa328a18b3: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
- ea5eb74a65f20ce28fa0a94ea851915d4a6f83da: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
- beea5305b071820e2b128a55c5ca384caf470fdd: 8331907: BigInteger and BigDecimal should use optimized division
- 440782e0160f867f08afbec0abf48d557a522c72: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
- 5ded8da676d62158d0011086d7f80ff2c9096e13: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
- 7c2c24fc0511b36132952c96be46eea5904a53c5: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
- ff4bf1cf9f18547cff8f484433c3c55b4c288aaa: 8332102: Add
@sinceto package-info ofjdk.security.jarsigner - abf54bb1e6da6d7bc432b3e9bb3ff164a895bd3e: 8332100: Add missing
@sinceto KeyValue::EC_TYPE injava.xml.crypto - 1484153c1a092cefc20270b35aa1e508280843a4: 8332080: Update troff man page for javadoc
- 391bbbc7d0fb95b0cd55e2f56c43bee019aeab7f: 8330584: IGV: XML does not save all node properties
- ... and 185 more: https://git.openjdk.org/jdk/compare/16c7dcdb04a7c220684a20eb4a0da4505ae03813...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @bplb) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@txominpelu The following label will be automatically applied to this pull request:
nio
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@txominpelu Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@txominpelu Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
Webrevs
- 05: Full - Incremental (868a40fd)
- 04: Full - Incremental (39e348b3)
- 03: Full - Incremental (e7fd93af)
- 02: Full - Incremental (e73fc764)
- 01: Full - Incremental (08744f42)
- 00: Full (3bbaa643)
@txominpelu This pull request has not yet been marked as ready for integration.
Oops sorry, I thought that integrating meant merging the latest changes from master into my PR but I misunderstood and that's just a side effect of calling /integrate. Now, I get that integrate is meant to merge the PR to the master branch and, as a part of that merge process, it first merges the latest changes from master into the branch.
The update to the test looks okay to me, and I think useful to have the test changed to check > 0 is good. It might be clearer to have it fail if <= 0 of course.
I assume you'll bump the end date in the copyright header.
Thanks @AlanBateman !
I've updated the copyright in: https://github.com/openjdk/jdk/pull/19021/commits/78af373b3df429ea2683293517f2c75b0c12b00e
And updated the failure condition to <= in: https://github.com/openjdk/jdk/pull/19021/commits/868a40fddb6d6167e00cc0dbfc39470c9cbf4985
@txominpelu You need to remove the integration blocker by changing the title of this PR to match the summary of the issue
8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
@txominpelu You need to remove the integration blocker by changing the title of this PR to match the summary of the issue
8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
Thanks @bplb , I've fixed the title of the PR.
@txominpelu Your change (at version 868a40fddb6d6167e00cc0dbfc39470c9cbf4985) is now ready to be sponsored by a Committer.
Going to push as commit e91492ab4333c61f39b50eb428fa932131a5b908.
Since your change was applied there have been 198 commits pushed to the master branch:
- 95a601316de06b4b0fbf6e3c7777be5d2a1ca978: 8332042: Move MEMFLAGS to its own include file
- 5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e: 8331858: [nmt] VM.native_memory statistics should work in summary mode
- 4ba74475d44831c1fe49359458163cd1567e9619: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
- 7ce4a13c0a891e606480e138f4025ffa328a18b3: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
- ea5eb74a65f20ce28fa0a94ea851915d4a6f83da: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
- beea5305b071820e2b128a55c5ca384caf470fdd: 8331907: BigInteger and BigDecimal should use optimized division
- 440782e0160f867f08afbec0abf48d557a522c72: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
- 5ded8da676d62158d0011086d7f80ff2c9096e13: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
- 7c2c24fc0511b36132952c96be46eea5904a53c5: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
- ff4bf1cf9f18547cff8f484433c3c55b4c288aaa: 8332102: Add
@sinceto package-info ofjdk.security.jarsigner - ... and 188 more: https://git.openjdk.org/jdk/compare/16c7dcdb04a7c220684a20eb4a0da4505ae03813...master
Your commit was automatically rebased without conflicts.
@bplb @txominpelu Pushed as commit e91492ab4333c61f39b50eb428fa932131a5b908.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.