8321003: RISC-V: C2 MulReductionVI

[Hamlin-Li]

Hi, Can you help to review this patch to implement MulReductionVI/MulReductionVL/MulReductionVF/MulReductionVD? On riscv, there is no straightforward instructions to do it, but we can do it with a reduction tree, which could reduce the time complexity to lg(N). Thanks

Performance

TBD

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issues

• JDK-8321003: RISC-V: C2 MulReductionVI (Sub-task - P4)
• JDK-8321004: RISC-V: C2 MulReductionVL (Sub-task - P4)
• JDK-8321005: RISC-V: C2 MulReductionVF (Sub-task - P4)
• JDK-8321006: RISC-V: C2 MulReductionVD (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19015/head:pull/19015
$ git checkout pull/19015

Update a local copy of the PR:
$ git checkout pull/19015
$ git pull https://git.openjdk.org/jdk.git pull/19015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19015

View PR using the GUI difftool:
$ git pr show -t 19015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19015.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[Hamlin-Li]

/solves JDK-8321004 /solves JDK-8321005 /solves JDK-8321006

[openjdk[bot]]

@Hamlin-Li Adding additional issue to solves list: 8321004: RISC-V: C2 MulReductionVL.

[openjdk[bot]]

@Hamlin-Li Adding additional issue to solves list: 8321005: RISC-V: C2 MulReductionVF.

[openjdk[bot]]

@Hamlin-Li Adding additional issue to solves list: 8321006: RISC-V: C2 MulReductionVD.

[openjdk[bot]]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full (6c7bda7b)
• 00: Full (aedec772)

[openjdk[bot]]

@Hamlin-Li this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout mul-reduction-vx
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[bridgekeeper[bot]]

@Hamlin-Li This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Hamlin-Li]

in progress...

[robehn]

Can you convert to draft please?

[Hamlin-Li]

Can you convert to draft please?

Thanks for the tip.

[bridgekeeper[bot]]

@Hamlin-Li This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@Hamlin-Li This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.