jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8321008: RISC-V: C2 MulAddVS2VI

Open Hamlin-Li opened this issue 1 year ago • 9 comments

Hi, Can you help to review the patch?

The motivation is to implement MulAddVS2VI. But to enable MulAddVS2VI, MulAddS2I is prerequisite, although MulAddS2I does not bring extra benefit on riscv as we don't have an specific instruction of muladd on riscv. So, this patch implement both MulAddVS2VI and MulAddS2I.

Thanks


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18919/head:pull/18919
$ git checkout pull/18919

Update a local copy of the PR:
$ git checkout pull/18919
$ git pull https://git.openjdk.org/jdk.git pull/18919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18919

View PR using the GUI difftool:
$ git pr show -t 18919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18919.diff

Webrev

Link to Webrev Comment

Hamlin-Li avatar Apr 23 '24 15:04 Hamlin-Li

:wave: Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 23 '24 15:04 bridgekeeper[bot]

/solves JDK-8320986

Hamlin-Li avatar Apr 23 '24 15:04 Hamlin-Li

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Apr 23 '24 15:04 openjdk[bot]

@Hamlin-Li Adding additional issue to solves list: 8320986: RISC-V: C2 MulAddS2I.

openjdk[bot] avatar Apr 23 '24 15:04 openjdk[bot]

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Apr 23 '24 15:04 openjdk[bot]

Webrevs

mlbridge[bot] avatar Apr 23 '24 15:04 mlbridge[bot]

@Hamlin-Li this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout mula-vs-2-vi
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk[bot] avatar May 09 '24 23:05 openjdk[bot]

@Hamlin-Li This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 07 '24 01:06 bridgekeeper[bot]

in progress...

Hamlin-Li avatar Jun 07 '24 09:06 Hamlin-Li

@Hamlin-Li This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 07 '24 19:08 bridgekeeper[bot]

@Hamlin-Li This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Oct 02 '24 22:10 bridgekeeper[bot]