8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32

[voitylov]

trafficstars

TestLargeMonitorOffset was introduced by 8310844 with a fix for the AArch64 platform. The same issue needs to be fixed for ARM32. With this change, we add the large slot_offset handling to the ARM32 version of IR_Assembler::osr_entry().

Testing: jtreg hotspot, jtreg jdk tier1-3.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32 (Bug - P3)

Reviewers

• Sergey Nazarkin (@snazarkin - no project role)
• Dmitry Samersoff (@dsamersoff - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18891/head:pull/18891
$ git checkout pull/18891

Update a local copy of the PR:
$ git checkout pull/18891
$ git pull https://git.openjdk.org/jdk.git pull/18891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18891

View PR using the GUI difftool:
$ git pr show -t 18891

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18891.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back avoitylov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@voitylov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32

Reviewed-by: snazarki, dsamersoff

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 981 new commits pushed to the master branch:

• b83766e59063a41ea8801ac9e7c15dce67727c62: 8335632: jdk/jfr/api/consumer/streaming/TestJVMExit.java failed with "Process [...] is no longer alive"
• 7efe16038e5df9894a265ea1214068060f595c4e: 8335730: JFR: Clean up jdk.jfr
• ff49f677ee5017019c90823bc412ceb90068ffbd: 8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file
• 194425d7875ef42fce52516ed59c81ee97720399: 8335645: j.u.Formatter#trailingZeros improved with String repeat
• c8acea87e2c5ba6672c011ec4e57a53c55fee74b: 8335706: G1: Remove unused G1ConcurrentRefine::RemSetSamplingClosure::_cset
• bdf470b3b8f8814cb29f2877490d5bc1e79bdecb: 8335742: Problemlist gc/g1/TestMixedGCLiveThreshold.java#25percent with virtual threads
• 6409ec336af647044d0746c219496ad070de5e9d: 8335711: G1: Remove unused bot_updates argument in G1AllocRegion constructor
• 4ec1ae109710aa150e27acf5706475d335c4655c: 8331385: G1: Prefix HeapRegion helper classes with G1
• b9d8056d5c1528198ad373f9b4a09547e2fcabd6: 8332124: Jcmd should recognise options that look like requests for help
• cff9e246cc2fbd3914f40bb71daa85dcf7731396: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs
• ... and 971 more: https://git.openjdk.org/jdk/compare/3e185c70feef3febf75c58a5d4d394a4b772105f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dsamersoff) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

@voitylov The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (9799b250)

[snazarkin]

I've checked the patch (one may need to use a workaround ). The JDK crashes without the patch, and passes with the patch.

[bridgekeeper[bot]]

@voitylov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bulasevich]

Looks good

[voitylov]

/integrate

[openjdk[bot]]

@voitylov Your change (at version 9799b25019d72c8e89c62ecbf8c0c3dd8c18310a) is now ready to be sponsored by a Committer.

[dsamersoff]

/sponsor

[openjdk[bot]]

Going to push as commit 0e0dfca21f64ecfcb3e5ed7cdc2a173834faa509. Since your change was applied there have been 1004 commits pushed to the master branch:

• f3ff4f7427c3c3f5cb2a115a61462bb9d28de1cd: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux
• 8f62f31dff564289a2422d58e8ecd5062d443b81: 8335906: [s390x] Test Failure: GTestWrapper.java
• 2a2964759c73b3b9ab6afaad109383c89952977b: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException
• 564a72e1dba0f145600c8e7eff66992fbf294df0: 8335955: JDK-8335742 wrongly used a "JDK-" prefix in the problemlist bug number
• 9c7a6eabb93c570fdb74076edc931576ed6be3e0: 8312125: Refactor CDS enum class handling
• bb1f8a1698553d5962569ac8912edd0d7ef010dd: 8335904: Fix invalid comment in ShenandoahLock
• babf6df7d97e4beedb25e689634d999412c1e950: 8334757: AssertionError: Missing type variable in where clause
• 3733fe3a207078b585421cd2a098e808fafaa817: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @
• 3a87eb5c4606ce39970962895315567e8606eba7: 8335126: Shenandoah: Improve OOM handling
• 284671a1e4fb5bfe15b20b7f41fc24415b1235ed: 8335449: runtime/cds/DeterministicDump.java fails with File content different at byte ...
• ... and 994 more: https://git.openjdk.org/jdk/compare/3e185c70feef3febf75c58a5d4d394a4b772105f...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@dsamersoff @voitylov Pushed as commit 0e0dfca21f64ecfcb3e5ed7cdc2a173834faa509.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.