jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8330061: Cleanup: follow code heaps order in CodeCache initialization and logging, code heap info in logs

Open dchuyko opened this issue 1 year ago • 5 comments

This is an additional tiny cleanup after CodeCache::initialize_heaps refactoring (JDK-8311248). CodeCache::initialize_heaps: code heaps info is printed in code heaps order, final size adjustments and flags are made in code heaps order. CodeCache::allocate: assertion message contains blob type. CodeCache::print_trace: name of the heap containing the method is printed.

Testing: jtreg test/hotspot/jtreg/compiler/codecache, tier1, tier2.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8330061: Cleanup: follow code heaps order in CodeCache initialization and logging, code heap info in logs (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18732/head:pull/18732
$ git checkout pull/18732

Update a local copy of the PR:
$ git checkout pull/18732
$ git pull https://git.openjdk.org/jdk.git pull/18732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18732

View PR using the GUI difftool:
$ git pr show -t 18732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18732.diff

Webrev

Link to Webrev Comment

dchuyko avatar Apr 10 '24 21:04 dchuyko

:wave: Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 10 '24 21:04 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Apr 10 '24 22:04 openjdk[bot]

@dchuyko The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Apr 10 '24 22:04 openjdk[bot]

Webrevs

mlbridge[bot] avatar Apr 10 '24 22:04 mlbridge[bot]

@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 16 '24 18:05 bridgekeeper[bot]

@dchuyko This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jun 13 '24 21:06 bridgekeeper[bot]