8329839: Cleanup ZPhysicalMemoryBacking trace logging

[xmas92]

On bsd the MB scaling is only performed on the length and not the base offset so the numbers printed are wrong.

On all other platforms the zoffset type is used incorrectly and should use zoffset_end when printing offsets that point to the end of a range.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8329839: Cleanup ZPhysicalMemoryBacking trace logging (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18671/head:pull/18671
$ git checkout pull/18671

Update a local copy of the PR:
$ git checkout pull/18671
$ git pull https://git.openjdk.org/jdk.git pull/18671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18671

View PR using the GUI difftool:
$ git pr show -t 18671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18671.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329839: Cleanup ZPhysicalMemoryBacking trace logging

Reviewed-by: stefank, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 518 new commits pushed to the master branch:

• 391bbbc7d0fb95b0cd55e2f56c43bee019aeab7f: 8330584: IGV: XML does not save all node properties
• adaa509b6ed3d12569b8e5f2ec802cef22ab53c7: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
• 5a8df4106ac5386eb72e874dcadf2b18defe27d8: 8331535: Incorrect prompt for Console.readLine
• 3e3f7cf4bddf243fddfeac8cfc1d9b2a1be55043: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof
• d517d2df451e135583083ed3684d7d3241b36f76: 8331764: C2 SuperWord: refactor _align_to_ref/_mem_ref_for_main_loop_alignment
• 5053b70a7fc67ce9b73dbeecbdd88fbc34d45e04: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock
• 32c7681cf310c87669c502c4a8b62a7fecc93360: 8332029: Provide access to initial value of stderr via JavaLangAccess
• f9a1d3381b12c97784c11649be079147c85939c0: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
• b87a7e990631c8b402578f645397b2aeda8927bb: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator
• 1dac34fa757f1d603f0bc9b9c1994c114c276add: 8331098: [Aarch64] Fix crash in Arrays.equals() intrinsic with -CCP
• ... and 508 more: https://git.openjdk.org/jdk/compare/8efd7aa6c1671fa7d40c5c43bed140a493cfcf72...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (6730f0a5)

[bridgekeeper[bot]]

@xmas92 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[xmas92]

Thanks for the reviews. /integrate

[openjdk[bot]]

Going to push as commit c642f44bbe1e4cdbc23496a34ddaae30990ce7c0. Since your change was applied there have been 536 commits pushed to the master branch:

• d04ac14bdbab4187d0be98b8471f90be8a14f649: 8332236: javac crashes with module imports and implicitly declared class
• 4e77cf881d031e5b0320915b3eabd7702e560291: 8330795: C2: assert((uint)type <= T_CONFLICT && _zero_type[type] != nullptr) failed: bad type with -XX:-UseCompressedClassPointers
• 7b4ba7f90ab9ea5e1070c79534c587dad17d1bdd: 8325932: Replace ATTRIBUTE_NORETURN with direct [[noreturn]]
• 0bb5ae645165b97527ecccf02308df6072c363d8: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
• 4d32c607a4b496bf2bb09e54167ecbbab5569a0c: 8322008: Exclude some CDS tests from running with -Xshare:off
• e91492ab4333c61f39b50eb428fa932131a5b908: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
• 95a601316de06b4b0fbf6e3c7777be5d2a1ca978: 8332042: Move MEMFLAGS to its own include file
• 5a4415a6bddb25cbd5b87ff8ad1a06179c2e452e: 8331858: [nmt] VM.native_memory statistics should work in summary mode
• 4ba74475d44831c1fe49359458163cd1567e9619: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
• 7ce4a13c0a891e606480e138f4025ffa328a18b3: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
• ... and 526 more: https://git.openjdk.org/jdk/compare/8efd7aa6c1671fa7d40c5c43bed140a493cfcf72...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@xmas92 Pushed as commit c642f44bbe1e4cdbc23496a34ddaae30990ce7c0.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.