jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8328247: Remove redundant dir for tests converted from applet to main

Open prsadhuk opened this issue 1 year ago • 4 comments

Few tests were converted from applet manual to main using PassFailJFrame manual framework but the extra folder was not deleted

javax/swing/JFileChooser/6798062/bug6798062.java javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.html javax/swing/JInternalFrame/6726866/bug6726866.java

so tests are now moved to one folder up..


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8328247: Remove redundant dir for tests converted from applet to main (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18322/head:pull/18322
$ git checkout pull/18322

Update a local copy of the PR:
$ git checkout pull/18322
$ git pull https://git.openjdk.org/jdk.git pull/18322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18322

View PR using the GUI difftool:
$ git pr show -t 18322

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18322.diff

Webrev

Link to Webrev Comment

prsadhuk avatar Mar 15 '24 07:03 prsadhuk

:wave: Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 15 '24 07:03 bridgekeeper[bot]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328247: Remove redundant dir for tests converted from applet to main

Reviewed-by: tr, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
  • 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
  • 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
  • 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
  • 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
  • 71f9c4e7fd5818be6e79dead3caa02d738456ad6: 8320534: fatal error for the NMTBenchmark test run for the mainline build
  • bfba4894e14c9547735a6b4ae73ed423af09f0d4: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
  • 42aec8c5e72837400818d931855bade8acad8e9d: 8328146: Set LIBCXX automatically
  • 90ab52e598f74ed872fe404130d57f6596430727: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • ... and 9 more: https://git.openjdk.org/jdk/compare/06f4b7f54da03e57abfe8958e4354c1ecb7e3039...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 15 '24 07:03 openjdk[bot]

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 15 '24 07:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 15 '24 07:03 mlbridge[bot]

/integrate

prsadhuk avatar Mar 18 '24 06:03 prsadhuk

Going to push as commit ece4124f25f676da9bf2d1b7fd8e4394dd7d31af. Since your change was applied there have been 19 commits pushed to the master branch:

  • d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
  • 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
  • 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
  • 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
  • 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
  • 71f9c4e7fd5818be6e79dead3caa02d738456ad6: 8320534: fatal error for the NMTBenchmark test run for the mainline build
  • bfba4894e14c9547735a6b4ae73ed423af09f0d4: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
  • 42aec8c5e72837400818d931855bade8acad8e9d: 8328146: Set LIBCXX automatically
  • 90ab52e598f74ed872fe404130d57f6596430727: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • ... and 9 more: https://git.openjdk.org/jdk/compare/06f4b7f54da03e57abfe8958e4354c1ecb7e3039...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 18 '24 06:03 openjdk[bot]

@prsadhuk Pushed as commit ece4124f25f676da9bf2d1b7fd8e4394dd7d31af.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 18 '24 06:03 openjdk[bot]