jdk
jdk copied to clipboard
openjdk
JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main
This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8328190: Convert AWTPanelSmoothWheel.html applet test to main (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18312/head:pull/18312
$ git checkout pull/18312
Update a local copy of the PR:
$ git checkout pull/18312
$ git pull https://git.openjdk.org/jdk.git pull/18312/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18312
View PR using the GUI difftool:
$ git pr show -t 18312
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18312.diff
Webrev
:wave: Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@honkar-jdk This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8328190: Convert AWTPanelSmoothWheel.html applet test to main
Reviewed-by: azvegint, abhiscxk, aivanov
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 113 new commits pushed to the master branch:
- 23ebd9c3c69d09e6afe672d00b43da2ccc493480: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
- 4d932d615c78f45516a4f136398e7610546065a6: 8326853: Missing
@sincetags for Charset related methods added in Java 10 - ce7ebaa606f96fdfee66d300b56022d9903b5ae3: 8328812: Update and move siphash license
- b7a51dd0e8d56a9673b2c802d69019c23d43cb76: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main
- 739957ca1e3b9ac9131a68990178e92691744157: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main
- 13cf0707f903609c9bda99a9bf7511f494f9feae: 8328556: Do not extract large CKO_SECRET_KEY keys from the NSS Software Token
- 709410d8a4ca176c52d9c0abf80ed59eeb6bdaf3: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
- f207aa94f9296932276c2952252b263efc793b3f: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
- e80619a032c16d16de6e063e7650b60bc317ee7e: 8328680: Introduce JDK_LIB, and clean up module native compilation
- 638708cad8228f62caf633015973403164675560: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
- ... and 103 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@honkar-jdk The following label will be automatically applied to this pull request:
client
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 08: Full - Incremental (701e90a8)
- 07: Full - Incremental (ec673142)
- 06: Full - Incremental (6901a65c)
- 05: Full - Incremental (6b7591f0)
- 04: Full - Incremental (d81df883)
- 03: Full - Incremental (0299e8e2)
- 02: Full - Incremental (a2b9b95a)
- 01: Full - Incremental (627ec863)
- 00: Full (c6f6070e)
This PR has been updated to use PassFailJFrame's new logArea() feature. @azvegint @aivanov-jdk Please review.
@aivanov-jdk
I have changed the logic for MouseWheelEvents as below:
- wheelRotationCount was no longer required, hence removed it .
- checking for Math.abs(e.getPreciseWheelRotation()) value since it can be negative when mouse is scrolled down.
(e.getWheelRotation() != 0 && hiResWheelCount > 0)this condition looks to be sufficient to forcePass the test as we need only one complete non-zero wheelRotation value.- added JOptionPane for the warning message as suggested.
I somewhat dislike that the test completes too quickly when I use my mouse. Yes, you warn the tester the test is semi-automatic, yet I'd prefer giving the tester more time.
Technically, one event with e.getWheelRotation() != 0 is enough, that's right. It just doesn't feel right…
I somewhat dislike that the test completes too quickly when I use my mouse. Yes, you warn the tester the test is semi-automatic, yet I'd prefer giving the tester more time.
Technically, one event with
e.getWheelRotation() != 0is enough, that's right. It just doesn't feel right…
I run the test it with trackpad on my Windows laptop. Indeed, waiting for e.getWheelRotation() != 0 takes too long if e.getPreciseWheelRotation() is very small, it is 0.01 on Harshitha's laptop and on mine too.
When the value of e.getPreciseWheelRotation() > 0.10, it feels the test completes too fast.
We can change the sensitivity of the test. Is it worth the effort? Perhaps, it isn't.
Does anyone else have any comments?
Going to push as commit c7bbf849290b39b8e89290234d70d8333df24710.
Since your change was applied there have been 113 commits pushed to the master branch:
- 23ebd9c3c69d09e6afe672d00b43da2ccc493480: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
- 4d932d615c78f45516a4f136398e7610546065a6: 8326853: Missing
@sincetags for Charset related methods added in Java 10 - ce7ebaa606f96fdfee66d300b56022d9903b5ae3: 8328812: Update and move siphash license
- b7a51dd0e8d56a9673b2c802d69019c23d43cb76: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main
- 739957ca1e3b9ac9131a68990178e92691744157: 8328384: Convert java/awt/FileDialog/FileDialogOpenDirTest test to main
- 13cf0707f903609c9bda99a9bf7511f494f9feae: 8328556: Do not extract large CKO_SECRET_KEY keys from the NSS Software Token
- 709410d8a4ca176c52d9c0abf80ed59eeb6bdaf3: 8328679: Improve comment for UNSAFE_ENTRY_SCOPED in unsafe.cpp
- f207aa94f9296932276c2952252b263efc793b3f: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition
- e80619a032c16d16de6e063e7650b60bc317ee7e: 8328680: Introduce JDK_LIB, and clean up module native compilation
- 638708cad8228f62caf633015973403164675560: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
- ... and 103 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master
Your commit was automatically rebased without conflicts.
@honkar-jdk Pushed as commit c7bbf849290b39b8e89290234d70d8333df24710.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.