jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main

Open DamonGuy opened this issue 1 year ago • 4 comments

Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18307/head:pull/18307
$ git checkout pull/18307

Update a local copy of the PR:
$ git checkout pull/18307
$ git pull https://git.openjdk.org/jdk.git pull/18307/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18307

View PR using the GUI difftool:
$ git pr show -t 18307

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18307.diff

Webrev

Link to Webrev Comment

DamonGuy avatar Mar 14 '24 16:03 DamonGuy

:wave: Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 14 '24 16:03 bridgekeeper[bot]

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main

Reviewed-by: azvegint, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 164 new commits pushed to the master branch:

  • d3f3011d56267360d65841da3550eca79cf1575b: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
  • e5e7cd20eca0e5a5f0811d304a9659961dcf11c0: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
  • 1b68c731f2461a2f26e6d967dd3f94e217b4d1f4: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
  • e0373e01fece310d12859207cc5e233f68b7607f: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main
  • 03c25b15eb73e594d1329be397cd34e206d2682b: 8328367: Convert java/awt/Component/UpdatingBootTime test to main
  • eebcc2181fe27f6aa10559233c7c58882a146f56: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • a68f5d7331c2e6c4bc51eee95abcbabb5a19b484: 8327879: Convert javax/swing/border/Test4760089.java applet test to main
  • 269163d509ec3c80983f55c5b47f472fa76be26c: 8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
  • 7231fd78aada80946b680e10227a356714d5c34b: 8328350: G1: Remove DO_DISCOVERED_AND_DISCOVERY
  • 4f8f48654e500e875d14e6b4707ab654acc59176: 8328012: Convert InputMethod (/java/awt/im) applet tests to main
  • ... and 154 more: https://git.openjdk.org/jdk/compare/c65d308973f1e2c41b6910fd844223597e70972f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 14 '24 16:03 openjdk[bot]

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 14 '24 16:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 14 '24 16:03 mlbridge[bot]

/integrate

DamonGuy avatar Mar 20 '24 16:03 DamonGuy

Going to push as commit 4e83f4cfc779e39cca0070b5729a508aeaa74654. Since your change was applied there have been 164 commits pushed to the master branch:

  • d3f3011d56267360d65841da3550eca79cf1575b: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
  • e5e7cd20eca0e5a5f0811d304a9659961dcf11c0: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
  • 1b68c731f2461a2f26e6d967dd3f94e217b4d1f4: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
  • e0373e01fece310d12859207cc5e233f68b7607f: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main
  • 03c25b15eb73e594d1329be397cd34e206d2682b: 8328367: Convert java/awt/Component/UpdatingBootTime test to main
  • eebcc2181fe27f6aa10559233c7c58882a146f56: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • a68f5d7331c2e6c4bc51eee95abcbabb5a19b484: 8327879: Convert javax/swing/border/Test4760089.java applet test to main
  • 269163d509ec3c80983f55c5b47f472fa76be26c: 8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
  • 7231fd78aada80946b680e10227a356714d5c34b: 8328350: G1: Remove DO_DISCOVERED_AND_DISCOVERY
  • 4f8f48654e500e875d14e6b4707ab654acc59176: 8328012: Convert InputMethod (/java/awt/im) applet tests to main
  • ... and 154 more: https://git.openjdk.org/jdk/compare/c65d308973f1e2c41b6910fd844223597e70972f...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 20 '24 16:03 openjdk[bot]

@DamonGuy Pushed as commit 4e83f4cfc779e39cca0070b5729a508aeaa74654.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 20 '24 16:03 openjdk[bot]