8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size

[lgxbslgx]

trafficstars

Hi all,

When an object size meets the following three conditions, the allocation will fail unexpectedly.

1. object_size > uncommitted_size
2. object_size > committed_but_unused_size
3. object_size < unused_size (unused_size equals uncommitted_size + committed_but_unused_size)

Please read the newly added test of this patch for the concrete case.

Thanks for taking the time to review.

Best Regrads, -- Guoxiong

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18304/head:pull/18304
$ git checkout pull/18304

Update a local copy of the PR:
$ git checkout pull/18304
$ git pull https://git.openjdk.org/jdk.git pull/18304/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18304

View PR using the GUI difftool:
$ git pr show -t 18304

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18304.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back gli! A progress list of the required criteria for merging this PR into pr/18303 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size

Reviewed-by: shade, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• c342188fd978dd94e7788fb0fb0345fd8c0eaa9a: 8328074: Add jcheck whitespace checking for assembly files
• 3c70f26b2f3fa9bc143e2506af30f9b1daf20022: 8328112: Remove CardTable::_guard_region
• 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
• ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
• 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
• 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
• 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
• ... and 3 more: https://git.openjdk.org/jdk/compare/90ab52e598f74ed872fe404130d57f6596430727...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

@lgxbslgx The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (9f1c0b28)
• 01: Full - Incremental (5c99942d)
• 00: Full (4e1e36d8)

[openjdk[bot]]

⚠️ @lgxbslgx This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[lgxbslgx]

⚠️ @lgxbslgx This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

This problem can be solved after https://github.com/openjdk/jdk/pull/18303 integrating. I shouldn't have merged the master so quickly.

[openjdk-notifier[bot]]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout FAILED-ALLOCATION
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[lgxbslgx]

@shipilev Thanks for your review. Waiting for another review.

[lgxbslgx]

@shipilev @tschatzl Thanks for the review.

/integrate

[openjdk[bot]]

Going to push as commit 7baec6622254fc21e315b974a213605a7605daac. Since your change was applied there have been 13 commits pushed to the master branch:

• c342188fd978dd94e7788fb0fb0345fd8c0eaa9a: 8328074: Add jcheck whitespace checking for assembly files
• 3c70f26b2f3fa9bc143e2506af30f9b1daf20022: 8328112: Remove CardTable::_guard_region
• 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
• ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
• d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
• 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
• 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
• 65a84c2642822862fa186f290f8d6e83537bea06: 8328006: refactor large anonymous inner class in HtmlDocletWriter
• 044f4ed55dfce7f1aed9e10accf459b4af9b975e: 8326979: (jdeps) improve the error message for FindException caused by InvalidModuleDescriptorException
• ... and 3 more: https://git.openjdk.org/jdk/compare/90ab52e598f74ed872fe404130d57f6596430727...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@lgxbslgx Pushed as commit 7baec6622254fc21e315b974a213605a7605daac.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.