JDK-8320675 : PrinterJob/SecurityDialogTest.java hangs

[Renjithkannath]

trafficstars

Hi Reviewers,

I have updated the test with PassFailJFrame with information panel, earlier this was informed through terminal. Please review and let me know your suggestions if any.

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8320675: PrinterJob/SecurityDialogTest.java hangs (Bug - P4)

Reviewers

• Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to 6e80eaa0

Contributors

• Alexey Ivanov <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18299/head:pull/18299
$ git checkout pull/18299

Update a local copy of the PR:
$ git checkout pull/18299
$ git pull https://git.openjdk.org/jdk.git pull/18299/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18299

View PR using the GUI difftool:
$ git pr show -t 18299

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18299.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320675: PrinterJob/SecurityDialogTest.java hangs

Co-authored-by: Alexey Ivanov <[email protected]>
Reviewed-by: aivanov, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 134 new commits pushed to the master branch:

• dea94f4445b9389339cf7ca0eef688ca56c17814: 8328300: Convert PrintDialogsTest.java from Applet to main program
• d32746ef4a0ce6fec558274244321991be141698: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
• 000f4d8d156a48939fd29f8b4dd84b3dfd7d9d95: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• fbeac98c84078a566c572abeba07c49e94bbf26b: 8328379: Convert URLDragTest.html applet test to main
• 96530bcc07514c3eda40fd6ffa74f197fe541dea: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• a112fc8bac8ddee87c8555b156519a2785d3223b: 8328225: Convert ImageDecoratedDnD.html applet test to main
• 4e83f4cfc779e39cca0070b5729a508aeaa74654: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• d3f3011d56267360d65841da3550eca79cf1575b: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
• e5e7cd20eca0e5a5f0811d304a9659961dcf11c0: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
• 1b68c731f2461a2f26e6d967dd3f94e217b4d1f4: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
• ... and 124 more: https://git.openjdk.org/jdk/compare/49d8008947534898e2ba36e2d81d87d6ae4b4c02...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @TejeshR13) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

@Renjithkannath The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (cc6d560d)
• 02: Full - Incremental (b95f9022)
• 01: Full - Incremental (6e80eaa0)
• 00: Full (ede65c0b)

[Renjithkannath]

/contributor add aivanov-jdk

[openjdk[bot]]

@Renjithkannath aivanov-jdk was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <[email protected]>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[Renjithkannath]

/contributor add @aivanov-jdk

[openjdk[bot]]

@Renjithkannath Contributor Alexey Ivanov <[email protected]> successfully added.

[aivanov-jdk]

/reviewers 2

[openjdk[bot]]

@aivanov-jdk The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[aivanov-jdk]

INSTRUCTIONS can be moved inside main.

No. Well, it can but what's the point?

IDE never suggests converting constants to local variables. It is because constants can be inlined by Java compiler.

Static or instance fields as well as local variables are usually kept. Converting a field to local variable reduces the size of the object.

[Renjithkannath]

/integrate

[openjdk[bot]]

@Renjithkannath Your change (at version cc6d560d8ddd252eaa8b8cd523c393eb7a335ea1) is now ready to be sponsored by a Committer.

[TejeshR13]

/sponsor

[openjdk[bot]]

Going to push as commit 9f5ad43358a4e209b4cd1c91bcc86b997f371548. Since your change was applied there have been 139 commits pushed to the master branch:

• 684678f9e83ed0a76541a31356894d170fd421db: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
• 93d1700f23d42cb35b6028c5d7d029c035711acf: 8328589: unify os::breakpoint among posix platforms
• a5a2eca155bf5d9a1f01d0f3f21bd19dd0a7bd4d: 8327683: Crash with primitive type pattern and generic expression in instanceof
• 65d9f119c401c26c9a6436f5c9a513f91bb8c753: 8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main
• 481473efce9f51a497e26002c6da52b0ddc9ea8f: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
• dea94f4445b9389339cf7ca0eef688ca56c17814: 8328300: Convert PrintDialogsTest.java from Applet to main program
• d32746ef4a0ce6fec558274244321991be141698: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs
• 000f4d8d156a48939fd29f8b4dd84b3dfd7d9d95: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
• fbeac98c84078a566c572abeba07c49e94bbf26b: 8328379: Convert URLDragTest.html applet test to main
• 96530bcc07514c3eda40fd6ffa74f197fe541dea: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• ... and 129 more: https://git.openjdk.org/jdk/compare/49d8008947534898e2ba36e2d81d87d6ae4b4c02...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@TejeshR13 @Renjithkannath Pushed as commit 9f5ad43358a4e209b4cd1c91bcc86b997f371548.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.