8327994: Update code gen in CallGeneratorHelper

[JornVernee]

Update the code gen code in CallGeneratorHelper to reflect the latest state of the libTest(Downcall/Upcall)(Stack).c and shared.h files.

• The previous code wanted users to pipe stdout into a file. But, since we have 5 files that need to be created, and the names of those files is important too, I've changed the script to write to those files directly instead.
• I moved the definition of S_FFFF to libVarArgs.c where it's used, as it's not actually generated by CallGeneratorHelper.
• GitHub doesn't render the changes to some of the files, but those files only contain either white space changes (some missing spaces after ,), and copyright header updates.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8327994: Update code gen in CallGeneratorHelper (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18269/head:pull/18269
$ git checkout pull/18269

Update a local copy of the PR:
$ git checkout pull/18269
$ git pull https://git.openjdk.org/jdk.git pull/18269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18269

View PR using the GUI difftool:
$ git pr show -t 18269

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18269.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@JornVernee The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (d282ecbd)
• 00: Full (e66b7671)

[openjdk[bot]]

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327994: Update code gen in CallGeneratorHelper

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 128 new commits pushed to the master branch:

• 4e83f4cfc779e39cca0070b5729a508aeaa74654: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• d3f3011d56267360d65841da3550eca79cf1575b: 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream
• e5e7cd20eca0e5a5f0811d304a9659961dcf11c0: 8328386: Convert java/awt/FileDialog/FileNameOverrideTest test to main
• 1b68c731f2461a2f26e6d967dd3f94e217b4d1f4: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
• e0373e01fece310d12859207cc5e233f68b7607f: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main
• 03c25b15eb73e594d1329be397cd34e206d2682b: 8328367: Convert java/awt/Component/UpdatingBootTime test to main
• eebcc2181fe27f6aa10559233c7c58882a146f56: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
• a68f5d7331c2e6c4bc51eee95abcbabb5a19b484: 8327879: Convert javax/swing/border/Test4760089.java applet test to main
• 269163d509ec3c80983f55c5b47f472fa76be26c: 8328387: Convert java/awt/Frame/FrameStateTest/FrameStateTest.html applet test to main
• 7231fd78aada80946b680e10227a356714d5c34b: 8328350: G1: Remove DO_DISCOVERED_AND_DISCOVERY
• ... and 118 more: https://git.openjdk.org/jdk/compare/49d8008947534898e2ba36e2d81d87d6ae4b4c02...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JornVernee]

No changes in libTestDowncallStack.c (not even minor ones) ?

No, there was a 'missing' space between the prefix parameters and the actual parameters of the stack variants, and between the arguments passed when that callback was called in the upcall lib (So, white space only). libTestDowncall.c didn't have any changes.

[JornVernee]

/integrate

[openjdk[bot]]

Going to push as commit ac2f8e5af8c88cd13038b113f82bb7c17a38aa40. Since your change was applied there have been 143 commits pushed to the master branch:

• c434b79cff33e08e4518e92ddddae996dffefe29: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
• 700679011e5e9191f5170209454d35cc82953362: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage
• 68170ae22233462e8925c75c4737be7f0ba9353d: 8328238: Convert few closed manual applet tests to main
• 9f5ad43358a4e209b4cd1c91bcc86b997f371548: 8320675: PrinterJob/SecurityDialogTest.java hangs
• 684678f9e83ed0a76541a31356894d170fd421db: 8328633: s390x: Improve vectorization of Match.sqrt() on floats
• 93d1700f23d42cb35b6028c5d7d029c035711acf: 8328589: unify os::breakpoint among posix platforms
• a5a2eca155bf5d9a1f01d0f3f21bd19dd0a7bd4d: 8327683: Crash with primitive type pattern and generic expression in instanceof
• 65d9f119c401c26c9a6436f5c9a513f91bb8c753: 8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main
• 481473efce9f51a497e26002c6da52b0ddc9ea8f: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main
• dea94f4445b9389339cf7ca0eef688ca56c17814: 8328300: Convert PrintDialogsTest.java from Applet to main program
• ... and 133 more: https://git.openjdk.org/jdk/compare/49d8008947534898e2ba36e2d81d87d6ae4b4c02...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@JornVernee Pushed as commit ac2f8e5af8c88cd13038b113f82bb7c17a38aa40.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.