jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main

Open prsadhuk opened this issue 1 year ago • 4 comments

Conversion of manual applet test to main based using PassFailJFrame manual framework


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18263/head:pull/18263
$ git checkout pull/18263

Update a local copy of the PR:
$ git checkout pull/18263
$ git pull https://git.openjdk.org/jdk.git pull/18263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18263

View PR using the GUI difftool:
$ git pr show -t 18263

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18263.diff

Webrev

Link to Webrev Comment

prsadhuk avatar Mar 13 '24 07:03 prsadhuk

:wave: Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 13 '24 07:03 bridgekeeper[bot]

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 13 '24 07:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 13 '24 07:03 mlbridge[bot]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327757: Convert javax/swing/JSlider/6524424/bug6524424.java applet to main

Reviewed-by: abhiscxk, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 214 new commits pushed to the master branch:

  • 652fb3aa48fdfe09e827c2a06f76b3a69c711b74: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test to main
  • 9059727df135dc90311bd476124f090b5766092b: 8327182: Move serverAlias into the loop
  • 2dd5fba3bd37c577b8442b67a67dbcb22b9a530e: 8319889: Vector API tests trigger VM crashes with -XX:+StressIncrementalInlining
  • 3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."
  • c901da48e30d53cb8e4e3c1f0584c5f2d3d095f1: 8327098: GTest needs larger combination limit
  • 9e32db266e4c3cc9be273fa6b77112832a43ba4a: 8328309: Remove malformed masked shift instruction selection patterns
  • fc0472baf9bad298e853bf2ca3d10dc9415272cd: 8328000: Convert /java/awt/im/8154816/bug8154816.java applet test to main
  • 85fc47c81af81a595dc88e61454d8ba2d860f301: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
  • 569b05addf69698fc93026b4dca69bc6ca0920b6: 8327818: Implement Kerberos debug with sun.security.util.Debug
  • dec68d7e36a9436468594416272c44a2afbece8d: 8328234: Remove unused nativeUtils files
  • ... and 204 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

/integrate

prsadhuk avatar Mar 19 '24 06:03 prsadhuk

Going to push as commit ac5b6cb2d42bdb8fb1a110ad33411b50cff4ea61. Since your change was applied there have been 214 commits pushed to the master branch:

  • 652fb3aa48fdfe09e827c2a06f76b3a69c711b74: 8328154: Convert sun/java2d/loops/CopyAreaSpeed.java applet test to main
  • 9059727df135dc90311bd476124f090b5766092b: 8327182: Move serverAlias into the loop
  • 2dd5fba3bd37c577b8442b67a67dbcb22b9a530e: 8319889: Vector API tests trigger VM crashes with -XX:+StressIncrementalInlining
  • 3f2e849c54c2a9c55e3b5c9f5a6d3478b83144e3: 8280392: java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java failed with "RuntimeException: Test failed."
  • c901da48e30d53cb8e4e3c1f0584c5f2d3d095f1: 8327098: GTest needs larger combination limit
  • 9e32db266e4c3cc9be273fa6b77112832a43ba4a: 8328309: Remove malformed masked shift instruction selection patterns
  • fc0472baf9bad298e853bf2ca3d10dc9415272cd: 8328000: Convert /java/awt/im/8154816/bug8154816.java applet test to main
  • 85fc47c81af81a595dc88e61454d8ba2d860f301: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
  • 569b05addf69698fc93026b4dca69bc6ca0920b6: 8327818: Implement Kerberos debug with sun.security.util.Debug
  • dec68d7e36a9436468594416272c44a2afbece8d: 8328234: Remove unused nativeUtils files
  • ... and 204 more: https://git.openjdk.org/jdk/compare/b7540df6a4279c63e69d32b9d9834f7a427478d1...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 19 '24 06:03 openjdk[bot]

@prsadhuk Pushed as commit ac5b6cb2d42bdb8fb1a110ad33411b50cff4ea61.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 19 '24 06:03 openjdk[bot]