jdk icon indicating copy to clipboard operation
jdk copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests to main

Open honkar-jdk opened this issue 1 year ago • 5 comments

Following InputMethod applet tests are converted to main using PassFailJFrame

  1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java)
  2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java)
  • test instructions are updated to make to more clear
  • tests renamed
  • moved one directory above - /java/awt/im/
  • html file deleted.

Two tests are updated as part of this PR as they are similar, details here https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598

Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8328012: Convert InputMethod (/java/awt/im) applet tests to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18251/head:pull/18251
$ git checkout pull/18251

Update a local copy of the PR:
$ git checkout pull/18251
$ git pull https://git.openjdk.org/jdk.git pull/18251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18251

View PR using the GUI difftool:
$ git pr show -t 18251

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18251.diff

Webrev

Link to Webrev Comment

honkar-jdk avatar Mar 12 '24 19:03 honkar-jdk

:wave: Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 12 '24 20:03 bridgekeeper[bot]

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 12 '24 20:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 12 '24 20:03 mlbridge[bot]

java/awt/im/8148984/bug8148984.java (tests comma character) & test/jdk/java/awt/im/8132503/bug8132503.java (tests fullstop character) are similar so I'm using the same PR to update both. These tests essentially have similar instructions and test settings except testing a different character. As such these can be combined as a single test, but the instruction may become long and complex hence keeping them as separate tests.

honkar-jdk avatar Mar 12 '24 21:03 honkar-jdk

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328012: Convert InputMethod (/java/awt/im) applet tests to main

Reviewed-by: azvegint, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 169 new commits pushed to the master branch:

  • 9214a62f26917162b3ff2144a1f3f9cde3b808fa: 8328341: Remove deprecated per-thread compiler stats in sun.management
  • 132921683bc9860ce2ba89729dcd989b10b89aa2: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized
  • 3b305d502b84b7f1cfa378a9c274ef0b9ee52524: 8313306: More sensible memory reservation logging
  • f140eb4c3a47e1479d62fe1eef16bbbea92892bc: 8297879: javadoc link to preview JEP 1000 has grouping character comma
  • 5f2a92d954ce485d372c3cb3e5118556b1d076c3: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main
  • 2094ff3c7ad829355bf13760d9a19b37649b3517: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main
  • db4842c9d9696af311762cb9c809952c55b34623: 8328364: Remove redundant fields in 'BOTConstants'
  • c01095c0c9d4de1995d079be3356468196d9a25e: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
  • f1c69ccadb83306d1bb4860ff460a253af99643c: 8289822: G1: Make concurrent mark code owner of TAMSes
  • 5b6b514441fcbbaa210e2cad08ce2704fdf38191: 8325362: Allow to create a simple in-memory input JavaFileObject
  • ... and 159 more: https://git.openjdk.org/jdk/compare/a6dc4bc2b83c7240e573ac43f9b7a10191c58ed3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 13 '24 18:03 openjdk[bot]

/integrate

honkar-jdk avatar Mar 19 '24 17:03 honkar-jdk

Going to push as commit 4f8f48654e500e875d14e6b4707ab654acc59176. Since your change was applied there have been 170 commits pushed to the master branch:

  • 9ca4ae3d3b746f1d75036d189ff98f02b73b948f: 8328264: AArch64: remove UseNeon condition in CRC32 intrinsic
  • 9214a62f26917162b3ff2144a1f3f9cde3b808fa: 8328341: Remove deprecated per-thread compiler stats in sun.management
  • 132921683bc9860ce2ba89729dcd989b10b89aa2: 8328261: public lookup fails with IllegalAccessException when used while module system is being initialized
  • 3b305d502b84b7f1cfa378a9c274ef0b9ee52524: 8313306: More sensible memory reservation logging
  • f140eb4c3a47e1479d62fe1eef16bbbea92892bc: 8297879: javadoc link to preview JEP 1000 has grouping character comma
  • 5f2a92d954ce485d372c3cb3e5118556b1d076c3: 8328244: Convert javax/swing/JSlider/6742358/bug6742358.java applet test to main
  • 2094ff3c7ad829355bf13760d9a19b37649b3517: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main
  • db4842c9d9696af311762cb9c809952c55b34623: 8328364: Remove redundant fields in 'BOTConstants'
  • c01095c0c9d4de1995d079be3356468196d9a25e: 8328262: Convert javax/swing/JSplitPane/8132123/bug8132123.java applet test to main
  • f1c69ccadb83306d1bb4860ff460a253af99643c: 8289822: G1: Make concurrent mark code owner of TAMSes
  • ... and 160 more: https://git.openjdk.org/jdk/compare/a6dc4bc2b83c7240e573ac43f9b7a10191c58ed3...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 19 '24 17:03 openjdk[bot]

@honkar-jdk Pushed as commit 4f8f48654e500e875d14e6b4707ab654acc59176.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 19 '24 17:03 openjdk[bot]