jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8325871: Move StringTable and SymbolTable rehashing calls

Open coleenp opened this issue 1 year ago • 4 comments

Move the rehashing calls as a test in the concurrent work - ie. trigger concurrent work and check for the need to do rehashing.

Tested with tier1-7.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8325871: Move StringTable and SymbolTable rehashing calls (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18240/head:pull/18240
$ git checkout pull/18240

Update a local copy of the PR:
$ git checkout pull/18240
$ git pull https://git.openjdk.org/jdk.git pull/18240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18240

View PR using the GUI difftool:
$ git pr show -t 18240

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18240.diff

Webrev

Link to Webrev Comment

coleenp avatar Mar 12 '24 15:03 coleenp

:wave: Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 12 '24 15:03 bridgekeeper[bot]

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 12 '24 15:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 13 '24 12:03 mlbridge[bot]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325871: Move StringTable and SymbolTable rehashing calls

Reviewed-by: eosterlund, aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 119 new commits pushed to the master branch:

  • 86f17447362483162a5983c270e0b530d8d99354: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main
  • 7baec6622254fc21e315b974a213605a7605daac: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
  • c342188fd978dd94e7788fb0fb0345fd8c0eaa9a: 8328074: Add jcheck whitespace checking for assembly files
  • 3c70f26b2f3fa9bc143e2506af30f9b1daf20022: 8328112: Remove CardTable::_guard_region
  • 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
  • ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
  • d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
  • 07194195cefc568048fa639b6f8534ce3718c8d2: 8328236: module_entry in CDS map file has stale value
  • 0204aacb0305e94a7d6d5299a5ae835f3f71b030: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d: 8328242: Add a log area to the PassFailJFrame
  • ... and 109 more: https://git.openjdk.org/jdk/compare/586396cbb55a318fd6a2b4f1d8738258c6f8deff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

Yes, more cleanups needed in this place. Thanks for the reviews! /integrate

coleenp avatar Mar 18 '24 14:03 coleenp

Going to push as commit 7734466c4627c51b2c24b4b4dbf6db4184607aa3. Since your change was applied there have been 122 commits pushed to the master branch:

  • 9e98118f289e98ca9f3be2a274e0ddf8822aaa7c: 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
  • f3af91815a662b195938b26962a8670a4a692220: 8327945: Inline HasScavengableOops
  • fb390d202c8bbbbb87ba48fd01387feb35a1b768: 8327839: Crash with unboxing and widening primitive conversion in switch
  • 86f17447362483162a5983c270e0b530d8d99354: 8328248: Convert javax/swing/JSlider/6587742/bug6587742.java applet test to main
  • 7baec6622254fc21e315b974a213605a7605daac: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
  • c342188fd978dd94e7788fb0fb0345fd8c0eaa9a: 8328074: Add jcheck whitespace checking for assembly files
  • 3c70f26b2f3fa9bc143e2506af30f9b1daf20022: 8328112: Remove CardTable::_guard_region
  • 48717d63cc58f693f0917e61eafd672cd6af02ed: 8326333: jshell <TAB> completion on arrays is incomplete
  • ece4124f25f676da9bf2d1b7fd8e4394dd7d31af: 8328247: Remove redundant dir for tests converted from applet to main
  • d32ce65781c1d7815a69ceac720cdf3ae39caa9e: 8327651: Rename DictionaryEntry members related to protection domain
  • ... and 112 more: https://git.openjdk.org/jdk/compare/586396cbb55a318fd6a2b4f1d8738258c6f8deff...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Mar 18 '24 14:03 openjdk[bot]

@coleenp Pushed as commit 7734466c4627c51b2c24b4b4dbf6db4184607aa3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Mar 18 '24 14:03 openjdk[bot]