jdk
jdk copied to clipboard
openjdk
8325690: The scrollable element <div> with non-interactive content is not tabbable
The scrollable element <div> with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
https://bugs.openjdk.org/browse/JDK-8325690
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8325690: The scrollable element <div> with non-interactive content is not tabbable (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819
$ git checkout pull/17819
Update a local copy of the PR:
$ git checkout pull/17819
$ git pull https://git.openjdk.org/jdk.git pull/17819/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17819
View PR using the GUI difftool:
$ git pr show -t 17819
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17819.diff
Webrev
:wave: Welcome back psoujany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@psoujany The following label will be automatically applied to this pull request:
javadoc
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
Webrevs
- 39: Full - Incremental (32092858)
- 38: Full - Incremental (6641c9b8)
- 37: Full - Incremental (8748de2a)
- 36: Full - Incremental (a2b0bab7)
- 35: Full - Incremental (7717936a)
- 34: Full - Incremental (1534112b)
- 33: Full - Incremental (86030317)
- 32: Full - Incremental (e84e18d9)
- 31: Full - Incremental (8bf881e7)
- 30: Full - Incremental (0448657a)
- 29: Full - Incremental (a2055fe2)
- 28: Full - Incremental (265ee868)
- 27: Full - Incremental (aa84ed70)
- 26: Full - Incremental (4b4d829b)
- 25: Full - Incremental (268fbfa0)
- 24: Full - Incremental (cff5ca30)
- 23: Full - Incremental (95f99497)
- 22: Full - Incremental (eda64006)
- 21: Full - Incremental (a0ee85d7)
- 20: Full - Incremental (f85d6490)
- 19: Full - Incremental (885fa89f)
- 18: Full - Incremental (e31bcbc9)
- 17: Full - Incremental (3f32ed59)
- 16: Full - Incremental (67e1940e)
- 15: Full - Incremental (96719f9b)
- 14: Full - Incremental (cde1c600)
- 13: Full - Incremental (670a97c3)
- 12: Full - Incremental (75ea95d5)
- 11: Full - Incremental (40eb8328)
- 10: Full - Incremental (aa3bdaef)
- 09: Full - Incremental (bf10a578)
- 08: Full - Incremental (3434b5ae)
- 07: Full - Incremental (226aeae9)
- 06: Full - Incremental (f4e2dffd)
- 05: Full - Incremental (53a923c5)
- 04: Full - Incremental (ac770a01)
- 03: Full - Incremental (4b9e82bb)
- 02: Full - Incremental (a0f2773e)
- 01: Full - Incremental (3bd476af)
- 00: Full (aeb3ab45)
By default, a grid item cannot be smaller than the size of its content. overflow: auto on grind columns is causing accessibility checker to fail. Hence we propose to remove this property on the grid columns.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
⚠️ @psoujany This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).
@hns Thank you for the review. I tried to read more about table/grids and their associated ARIAs.
As per MDN, I added role=table aria-label for a table which doesn't has unique name and role=table aria-labelledby for the table having unique name and role=row tabindex=0 to the table rows making them tabbable. Could you please review these changes. Thank You.
@psoujany This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@psoujany This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.