8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly

[bulasevich]

This is a fix for an apparent code bug in CodeSection::alignment reported by the GCC warning.

Also, the section size initializer code is moved to initialize_misc() to fix the code path that works with uninitialized data.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10699/head:pull/10699
$ git checkout pull/10699

Update a local copy of the PR:
$ git checkout pull/10699
$ git pull https://git.openjdk.org/jdk pull/10699/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10699

View PR using the GUI difftool:
$ git pr show -t 10699

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10699.diff

[bridgekeeper[bot]]

:wave: Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@bulasevich The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 00: Full (effb437f)

[openjdk[bot]]

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly

Reviewed-by: phh, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 369 new commits pushed to the master branch:

• 6240431b381cd9327767cec03189aef55e23d8bd: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code
• 1164258ec7d173944f48cba368d6c50a07b4c283: 8295124: Atomic::add to pointer type may return wrong value
• d3eba859f9c87465a8f1c0dfd6dd5aef368d5853: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
• 028e8b3d5e7e1791a9ed0af244f74d21fb12ba81: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal
• faa6b662577a24eeb726ba525303b68b87269869: 8295715: Minimize disabled warnings in serviceability libs
• de1e0c57a75efee0b171f7ad341ce8db24c5507f: 8295719: Remove unneeded disabled warnings in jdk.sctp
• 9612cf998a22a7baec7f56ba256e5d3aa3ee8c7a: 8295529: Add link to JBS to README.md
• b37421e7578c108df87c24c93dcbc1f358f6c257: 8295564: Norwegian Nynorsk Locale is missing formatting
• 6707bfbc153de193b891c1ad3d4d8d0a6ee62307: 8029633: Raw inner class constructor ref should not perform diamond inference
• 7bc9692a5181a0db92ac2e0bca83dfe0bf2de05a: 8294670: Enhanced switch statements have an implicit default which does not complete normally
• ... and 359 more: https://git.openjdk.org/jdk/compare/0b56b822436a0662170c11777ff0009b89a667eb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bulasevich]

thanks!

[bulasevich]

/integrate

[openjdk[bot]]

Going to push as commit 50647187e8b0314ad67b0767f71c56fd50e8feaf. Since your change was applied there have been 374 commits pushed to the master branch:

• 8b010e014c44ffb728b7a8343d3298466f5252fa: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
• b35922be6de7b848a2982d6a278dbd205fc39e6a: 8295714: GHA ::set-output is deprecated and will be removed
• dfd2d83144fe4d78a7144acda6d9cb3e0045ea70: 8295657: SA: Allow larger object alignments
• a345df20d0a85b90e6703fba5582cacc5ba38a6d: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
• ef62b614d1760d198dcb7f5f0794fc3dc55587a7: 8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
• 6240431b381cd9327767cec03189aef55e23d8bd: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code
• 1164258ec7d173944f48cba368d6c50a07b4c283: 8295124: Atomic::add to pointer type may return wrong value
• d3eba859f9c87465a8f1c0dfd6dd5aef368d5853: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
• 028e8b3d5e7e1791a9ed0af244f74d21fb12ba81: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal
• faa6b662577a24eeb726ba525303b68b87269869: 8295715: Minimize disabled warnings in serviceability libs
• ... and 364 more: https://git.openjdk.org/jdk/compare/0b56b822436a0662170c11777ff0009b89a667eb...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@bulasevich Pushed as commit 50647187e8b0314ad67b0767f71c56fd50e8feaf.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.