jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8295273: Remove unused argument in [load/store]_sized_value on aarch64 and riscv

Open xmas92 opened this issue 3 years ago • 4 comments

Remove the unused argument Register [dst2/src2] in [load/store]_sized_value on aarch64 and riscv ports.

Seems like they were brought in in the initial ports JDK-8068054 JDK-8276799 as just straight signature copies of x86. The second register is only required on x86 for x86_32 support and is unused on riscv and aarch64.

Should be a trivial removal.

Testing: Cross-compiled for riscv and aarch64. Waiting for GHA


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8295273: Remove unused argument in [load/store]_sized_value on aarch64 and riscv

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10698/head:pull/10698
$ git checkout pull/10698

Update a local copy of the PR:
$ git checkout pull/10698
$ git pull https://git.openjdk.org/jdk pull/10698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10698

View PR using the GUI difftool:
$ git pr show -t 10698

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10698.diff

xmas92 avatar Oct 13 '22 12:10 xmas92

:wave: Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 13 '22 12:10 bridgekeeper[bot]

@xmas92 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 13 '22 12:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 13 '22 12:10 mlbridge[bot]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295273: Remove unused argument in [load/store]_sized_value on aarch64 and riscv

Reviewed-by: fyang, haosun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7e4868de7b0d3c20a35f06671ec0b68cfd441793: 8294847: Fix calculation of G1 effective scanned cards prediction

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 13 '22 13:10 openjdk[bot]

/integrate

xmas92 avatar Oct 18 '22 08:10 xmas92

Going to push as commit 6553065cab9ecb14390da8ec34e49aba940b213f. Since your change was applied there have been 56 commits pushed to the master branch:

  • b06f1b149c8f8a49d4e42c4b782a4b3a22aa79f6: 8294594: Fix cast-function-type warnings in signal handling code
  • 71aa8210910dbafe30eccc772eaa7747f46be0cd: 8295176: some langtools test pollutes source tree
  • bca7ab3c1109e6cff9b50ecdd3045cb0ae8f6953: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • c33ca0c5edd60454c58916cb588e5b2cfcc7b36a: 6229853: BasicTextAreaUI:create incompletely documents the possible returned View types
  • 358ac07255cc640cbcb9b0df5302d97891a34087: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
  • 490fcd0c2547cb4e564363f0cd121c777c3acc02: 8293833: Error mixing types with -XX:+UseCMoveUnconditionally -XX:+UseVectorCmov
  • 529cc48f355523fd162470b416a5081869adcf0e: 8295396: RISC-V: Cleanup useless CompressibleRegions
  • 692cdab2be7dfc6e12b127f8e2c97bc41536cb84: 8295016: Make the arraycopy_epilogue signature consistent with its usage
  • 21a825e059170e3a069b9f0982737c5839e6dae2: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
  • 8d751de3198675b22704cdccafaff2fc0fdd3f59: 8295231: Move all linking of native libraries to make
  • ... and 46 more: https://git.openjdk.org/jdk/compare/2f60675e06801b8ee495729d8bff2faec37ce509...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 18 '22 08:10 openjdk[bot]

@xmas92 Pushed as commit 6553065cab9ecb14390da8ec34e49aba940b213f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 18 '22 08:10 openjdk[bot]