jdk
jdk copied to clipboard
openjdk
8282958: Rendering issues of borders, TextFields on Windows High-DPI systems
This fix is based on a similar approach as described here https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648. We rescale the line border to render the Textfield border correctly, so that all sides of the Textfield border are of same thickness.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8282958: Rendering issues of borders, TextFields on Windows High-DPI systems
Contributors
- Alexey Ivanov
<[email protected]>
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10681/head:pull/10681
$ git checkout pull/10681
Update a local copy of the PR:
$ git checkout pull/10681
$ git pull https://git.openjdk.org/jdk pull/10681/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10681
View PR using the GUI difftool:
$ git pr show -t 10681
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10681.diff
:wave: Welcome back rajamah! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rajamah The following label will be automatically applied to this pull request:
client
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.
@rajamah This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8282958: Rendering issues of borders, TextFields on Windows High-DPI systems
Co-authored-by: Alexey Ivanov <[email protected]>
Reviewed-by: aivanov, honkar, kizune
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 268 new commits pushed to the master branch:
- 2fb64a4a4fd650e8767bb9959dc53f8c450d4060: 8296162: [aarch64] Remove unused Address::_is_lval
- 15b8b45178637acb07c33194f564acf807dfa5d4: 8296161: [aarch64] Remove unused "pcrel" addressing mode tag
- f829b5a73f699ca7fc513f491f77daae6c8f4ed9: 8280378: [IR Framework] Support IR matching for different compile phases
- da0ae5128a250bb7a5c6a7484589528db8220ed2: 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
- 0d0bd7bd409c0caa5edebe3d1eacf8e5bb48f984: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
- 37107fc1574a4191987420d88f7182e63c7da60c: 8296007: crash in runtime/DefineClass/NullClassBytesTest.java
- 4999f2cb164743ebf4badd3848a862609528dde3: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds
- 8480f87044f72e0312add190e75ee27030b7e10a: 8291974: PrivateCredentialPermission should not use local variable to enable debugging
- 590de37bd703bdae56e8b41c84f5fca5e5a00811: 8284842: Update Unicode Data Files to Version 15.0.0
- 16744b34498e7aac59caef8c9b1a3d4d15f8c22e: 8256660: Disable DTLS 1.0
- ... and 258 more: https://git.openjdk.org/jdk/compare/3c7ae1225f0d5575fd927a9b76fb40dc30e208cd...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @azuev-java) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@rajamah Your change (at version 815b0d791c8fd70280743741f298de1cb31d8411) is now ready to be sponsored by a Committer.
Going to push as commit 9911405e543dbe07767808bad88534abbcc03c5a.
Since your change was applied there have been 268 commits pushed to the master branch:
- 2fb64a4a4fd650e8767bb9959dc53f8c450d4060: 8296162: [aarch64] Remove unused Address::_is_lval
- 15b8b45178637acb07c33194f564acf807dfa5d4: 8296161: [aarch64] Remove unused "pcrel" addressing mode tag
- f829b5a73f699ca7fc513f491f77daae6c8f4ed9: 8280378: [IR Framework] Support IR matching for different compile phases
- da0ae5128a250bb7a5c6a7484589528db8220ed2: 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
- 0d0bd7bd409c0caa5edebe3d1eacf8e5bb48f984: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
- 37107fc1574a4191987420d88f7182e63c7da60c: 8296007: crash in runtime/DefineClass/NullClassBytesTest.java
- 4999f2cb164743ebf4badd3848a862609528dde3: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds
- 8480f87044f72e0312add190e75ee27030b7e10a: 8291974: PrivateCredentialPermission should not use local variable to enable debugging
- 590de37bd703bdae56e8b41c84f5fca5e5a00811: 8284842: Update Unicode Data Files to Version 15.0.0
- 16744b34498e7aac59caef8c9b1a3d4d15f8c22e: 8256660: Disable DTLS 1.0
- ... and 258 more: https://git.openjdk.org/jdk/compare/3c7ae1225f0d5575fd927a9b76fb40dc30e208cd...master
Your commit was automatically rebased without conflicts.
@aivanov-jdk @rajamah Pushed as commit 9911405e543dbe07767808bad88534abbcc03c5a.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.