8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure

[DamonGuy]

The previous change to AquaComboBoxUI had 1 pixel of overlap between the text field and the combo button. This caused a few pixels to darken sometimes when an editable combobox is displayed. Since this test passes sometimes and fails some other times, it was not initially detected.

Since these few darkening pixels occur due to the change in AquaComboBoxUI, no reasonable change to the test could really be made, and the change would need to be to the class for the combobox. This fix was tested with a high count repeat and no failures occurred for various macOS systems.

Also removing the test from the problem list.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure

Reviewers

• Jayathirth D V (@jayathirthrao - Reviewer) ⚠️ Review applies to 6ee1f92f
• Alisen Chung (@alisenchung - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10626/head:pull/10626
$ git checkout pull/10626

Update a local copy of the PR:
$ git checkout pull/10626
$ git pull https://git.openjdk.org/jdk pull/10626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10626

View PR using the GUI difftool:
$ git pr show -t 10626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10626.diff

[bridgekeeper[bot]]

:wave: Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@DamonGuy The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (8c0e0d8e)
• 01: Full (6ee1f92f)
• 00: Full (e614f080)

[honkar-jdk]

Suggestion: Does running the test - CustomComboBoxFocusTest.java with uiScale always set to 1 make it more robust?

[openjdk[bot]]

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure

Reviewed-by: jdv, achung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

• 8487c56f7ea224169d9d42efda9efb824266289f: 8295294: Misc cleanups in runtime/InvocationTests
• 0043d58c5d52c3b299a4b6dfcec34a7db5041aea: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
• 2e2a51ee22068e847b36f9a5f20bd37050eaabf8: 8295267: Improve G1 scan to merge ratio calculation
• dfcd9d538eba4b097083abe19d02d6d019236ac7: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files
• 2da079c64e880835c9c0eb36f5e63a7752ebb328: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks
• 449b52fd230786e818cdaf5000213ea746802e4d: 8295158: G1: Increase card-based cost sample reporting threshold
• 312985eea6237d75fae0f3c0cceb4f16e18b73b4: 8295156: G1: Improve constant other time calculation
• 786ce1c27b1da6096ad820170263d6b354e0d41a: 8295024: Cyclic constructor error is non-deterministic and inconsistent
• 1efa93e602455d7a032eb97cffa56da7337dd8f9: 8294844: Improve G1 young gen length revise trigger
• 3dbc38a2c903f533ace847a3bc0d2687f263fafd: 8295288: Some vm_flags tests associate with a wrong BugID
• ... and 71 more: https://git.openjdk.org/jdk/compare/1bfcc2790adbc273864c74faab0bd43613c75982...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jayathirthrao]

Additionally if we want to make javax/swing/plaf/aqua/CustomComboBoxFocusTest.java run at some default uiScale that also should be fine.

[DamonGuy]

Suggestion: Does running the test - CustomComboBoxFocusTest.java with uiScale always set to 1 make it more robust?

Sure, I can add a uiscale of 1 for robustness. Seems like a good idea since Jay's results at different uiscales may show variable pass rates at different uiscales.

[openjdk[bot]]

⚠️ @DamonGuy This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[DamonGuy]

/integrate

[openjdk[bot]]

@DamonGuy Your change (at version 8c0e0d8e9c901482b0111793ad033aa58c3be68b) is now ready to be sponsored by a Committer.

[DamonGuy]

@jayathirthrao Could you please sponsor this PR?

[jayathirthrao]

/sponsor

[openjdk[bot]]

Going to push as commit 358ac07255cc640cbcb9b0df5302d97891a34087. Since your change was applied there have been 104 commits pushed to the master branch:

• 490fcd0c2547cb4e564363f0cd121c777c3acc02: 8293833: Error mixing types with -XX:+UseCMoveUnconditionally -XX:+UseVectorCmov
• 529cc48f355523fd162470b416a5081869adcf0e: 8295396: RISC-V: Cleanup useless CompressibleRegions
• 692cdab2be7dfc6e12b127f8e2c97bc41536cb84: 8295016: Make the arraycopy_epilogue signature consistent with its usage
• 21a825e059170e3a069b9f0982737c5839e6dae2: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
• 8d751de3198675b22704cdccafaff2fc0fdd3f59: 8295231: Move all linking of native libraries to make
• f300ec8631b781938e6e96165ba23cda14a20f24: 8294546: document where javac differs when invoked via launcher and ToolProvider
• b269c51d10c353d9b7143b2239beb23c01352182: 8295395: Linux Alpha Zero builds fail after JDK-8292591
• ae60599e2ba75d80c3b4279903137b2c549f8066: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
• 4d37ef2d545c016e6c3ad52171ea961d4406726f: 8295262: Build binutils out of source tree
• 0919a3a0c198a5234b5ed9a3bb999564d2382a56: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
• ... and 94 more: https://git.openjdk.org/jdk/compare/1bfcc2790adbc273864c74faab0bd43613c75982...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@jayathirthrao @DamonGuy Pushed as commit 358ac07255cc640cbcb9b0df5302d97891a34087.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.