jdk icon indicating copy to clipboard operation
jdk copied to clipboard

JDK-8294546: document where javac differs when invoked via launcher and ToolProvider

Open jonathan-gibbons opened this issue 3 years ago • 4 comments

Please review a doc-only change to specify the differences between using different ways to invoke javac.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] Change requires a CSR request to be approved

Issues

  • JDK-8294546: document where javac differs when invoked via launcher and ToolProvider
  • JDK-8294687: document where javac differs when invoked via launcher and ToolProvider (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10566/head:pull/10566
$ git checkout pull/10566

Update a local copy of the PR:
$ git checkout pull/10566
$ git pull https://git.openjdk.org/jdk pull/10566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10566

View PR using the GUI difftool:
$ git pr show -t 10566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10566.diff

jonathan-gibbons avatar Oct 04 '22 23:10 jonathan-gibbons

:wave: Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 04 '22 23:10 bridgekeeper[bot]

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Oct 04 '22 23:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 04 '22 23:10 mlbridge[bot]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294546: document where javac differs when invoked via launcher and ToolProvider

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 159 new commits pushed to the master branch:

  • 7e4868de7b0d3c20a35f06671ec0b68cfd441793: 8294847: Fix calculation of G1 effective scanned cards prediction
  • 2f60675e06801b8ee495729d8bff2faec37ce509: 8294997: Improve ECC math operations
  • 94caecbe574227b232e22d9f56361f8ecd507be6: 8294906: Memory leak in PKCS11 NSS TLS server
  • 03e63a2b87e1bef6025722ec9a016312c55ebd81: 8295225: [JVMCI] codeStart should be cleared when entryPoint is cleared
  • 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec: 8291638: Keep-Alive timeout of 0 should close connection immediately
  • 6ae7e4d4aad5712cf2fe6ab9f98dc424fa4170cb: 8293984: Unnecessary Vector usage in PropertyEditorSupport
  • cd1357b0af0d4e3b459fcf88e67510502464bb90: 8295229: Try to verify gtest version
  • 90fb9a085bbaa9d1928a1cec9f00098b80577721: 8295102: Always load @lambda-form-invoker lines from default classlist
  • ac1941425bdb1a25aa3364eef9eb1092ee716761: 8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
  • 1961e81e02e707cd0c8241aa3af6ddabf7668589: 8289509: Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
  • ... and 149 more: https://git.openjdk.org/jdk/compare/3b1bc21727636cb50cd04d958031832f48fe17e3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 05 '22 16:10 openjdk[bot]

/integrate

jonathan-gibbons avatar Oct 17 '22 20:10 jonathan-gibbons

Going to push as commit f300ec8631b781938e6e96165ba23cda14a20f24. Since your change was applied there have been 203 commits pushed to the master branch:

  • b269c51d10c353d9b7143b2239beb23c01352182: 8295395: Linux Alpha Zero builds fail after JDK-8292591
  • ae60599e2ba75d80c3b4279903137b2c549f8066: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
  • 4d37ef2d545c016e6c3ad52171ea961d4406726f: 8295262: Build binutils out of source tree
  • 0919a3a0c198a5234b5ed9a3bb999564d2382a56: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
  • ec2981b83bc3ef6977b5f16d5222eb49b0ea49ad: 8293711: Factor out size parsing functions from arguments.cpp
  • 5d273b9f040a9884e2ae5b0f1409a3f9075c51c9: 8295278: Add parallel class loading tests
  • 172006c0e9433046252bd79e8864890ab7c0ce56: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
  • 7743345f6f73398f280fd18364b4cea10a6b0f2f: 8294314: Minimize disabled warnings in hotspot
  • 552d8a2821f03046896a728d6e4cec0ef754d3f4: 8295192: Use original configure command line when called from a script
  • cf07eaeb9291da725181832b8bb1dc54957ba886: 8295020: javac emits incorrect code for for-each on an intersection type.
  • ... and 193 more: https://git.openjdk.org/jdk/compare/3b1bc21727636cb50cd04d958031832f48fe17e3...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 17 '22 20:10 openjdk[bot]

@jonathan-gibbons Pushed as commit f300ec8631b781938e6e96165ba23cda14a20f24.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 17 '22 20:10 openjdk[bot]