jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1

Open e1iu opened this issue 3 years ago • 3 comments

C2_MacroAssembler::sve_vmask_tolong would fail on BITPERM supported SVE2 machine with "-XX:UseSVE=1".

BITPERM is an optional feature in SVE2. With this feature, VectorMaskToLong has a more efficent implementation. For other cases, it should generate SVE1 code.

[TEST] jdk/incubator/vector, hotspot/compiler/vectorapi passed on BITPERM supported SVE2 machine, with option -XX:UseSVE=(0, 1, 2).


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10443/head:pull/10443
$ git checkout pull/10443

Update a local copy of the PR:
$ git checkout pull/10443
$ git pull https://git.openjdk.org/jdk pull/10443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10443

View PR using the GUI difftool:
$ git pr show -t 10443

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10443.diff

e1iu avatar Sep 27 '22 09:09 e1iu

:wave: Welcome back eliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 27 '22 09:09 bridgekeeper[bot]

@theRealELiu The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Sep 27 '22 09:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 27 '22 09:09 mlbridge[bot]

@theRealAph Could you help to take a look? Thanks.

e1iu avatar Oct 17 '22 05:10 e1iu

@theRealELiu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1

Reviewed-by: njian, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 325 new commits pushed to the master branch:

  • cf07eaeb9291da725181832b8bb1dc54957ba886: 8295020: javac emits incorrect code for for-each on an intersection type.
  • b3bb3e6ed89f3abcaae584fcbe75688141e886cb: 8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le
  • 9005af3b90fbd3607aeb83efe1c4a6ffa5d104f0: 8295110: RISC-V: Mark out relocations as incompressible
  • 74a51ccc86525eb4b1eb2e5cb11e605ca9e9fc5d: 8292698: Improve performance of DataInputStream
  • d3781ac8a38943d8a20304e770b01d5418ee33d0: 8295009: RISC-V: Interpreter intrinsify Thread.currentThread()
  • e7d0ab227ff86bb65abf7fbeb135ce657454200b: 8295379: ProblemList java/lang/Float/Binary16Conversion.java in Xcomp mode on x64
  • 404e8de1559adade31df98a83919841f080b5b89: 8294865: x86: Improve the code generation of MulVB and MulVL
  • 2087424736f15a5a80a0492993a6cd74da87188a: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString
  • 8487c56f7ea224169d9d42efda9efb824266289f: 8295294: Misc cleanups in runtime/InvocationTests
  • 0043d58c5d52c3b299a4b6dfcec34a7db5041aea: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
  • ... and 315 more: https://git.openjdk.org/jdk/compare/379f3094db0b8afe90ed6b7a341164222744085f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 17 '22 08:10 openjdk[bot]

/integrate

e1iu avatar Oct 17 '22 13:10 e1iu

Going to push as commit 0919a3a0c198a5234b5ed9a3bb999564d2382a56. Since your change was applied there have been 330 commits pushed to the master branch:

  • ec2981b83bc3ef6977b5f16d5222eb49b0ea49ad: 8293711: Factor out size parsing functions from arguments.cpp
  • 5d273b9f040a9884e2ae5b0f1409a3f9075c51c9: 8295278: Add parallel class loading tests
  • 172006c0e9433046252bd79e8864890ab7c0ce56: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
  • 7743345f6f73398f280fd18364b4cea10a6b0f2f: 8294314: Minimize disabled warnings in hotspot
  • 552d8a2821f03046896a728d6e4cec0ef754d3f4: 8295192: Use original configure command line when called from a script
  • cf07eaeb9291da725181832b8bb1dc54957ba886: 8295020: javac emits incorrect code for for-each on an intersection type.
  • b3bb3e6ed89f3abcaae584fcbe75688141e886cb: 8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le
  • 9005af3b90fbd3607aeb83efe1c4a6ffa5d104f0: 8295110: RISC-V: Mark out relocations as incompressible
  • 74a51ccc86525eb4b1eb2e5cb11e605ca9e9fc5d: 8292698: Improve performance of DataInputStream
  • d3781ac8a38943d8a20304e770b01d5418ee33d0: 8295009: RISC-V: Interpreter intrinsify Thread.currentThread()
  • ... and 320 more: https://git.openjdk.org/jdk/compare/379f3094db0b8afe90ed6b7a341164222744085f...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 17 '22 13:10 openjdk[bot]

@theRealELiu Pushed as commit 0919a3a0c198a5234b5ed9a3bb999564d2382a56.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 17 '22 13:10 openjdk[bot]