8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes

[bulasevich]

trafficstars

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10392/head:pull/10392
$ git checkout pull/10392

Update a local copy of the PR:
$ git checkout pull/10392
$ git pull https://git.openjdk.org/jdk pull/10392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10392

View PR using the GUI difftool:
$ git pr show -t 10392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10392.diff

[bridgekeeper[bot]]

:wave: Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@bulasevich The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (19be053f)
• 03: Full - Incremental (102e33c7)
• 02: Full (59ff8c44)
• 01: Full - Incremental (f743a421)
• 00: Full (80693ef8)

[openjdk-notifier[bot]]

@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[openjdk-notifier[bot]]

@bulasevich Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[openjdk[bot]]

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293999: [JVMCI] need support for aligned constants in generated code larger than 8 bytes

Reviewed-by: dlong, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 823fd4a9dff52e8072b032ae6ddcab74d118185a: 8293785: Add a jtreg test for TraceOptoParse
• 754bd53137a1c596e6f1a7debb847cd563d95699: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
• 1fdbb1ba337b07dbcfb3c28c4fdeba74fee113dc: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
• cf5546b3ac63e305c0b9d040353503fb33d6ad7a: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
• 4b89fce0831f990d4b6af5e6e208342f68aed614: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
• d5d34241e21305379f1858556f225e7645cd294e: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bulasevich]

thanks!

[bulasevich]

/integrate

[openjdk[bot]]

Going to push as commit f3ca0cab75f2faf9ec88f7a380490c9589a27102. Since your change was applied there have been 9 commits pushed to the master branch:

• 8aa1526b443025b8606a3668262f46a9cb6ea6f6: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
• a44ebd5fbc164ccdd2cc9a64739776ebaa0a8011: 8295849: Consolidate Threads::owning_thread*
• 1c86cf5507a3126a00052d8c2d13c8fdc6e1da55: 8294672: Typo in description of JDWP VirtualMachine/AllThreads command
• 823fd4a9dff52e8072b032ae6ddcab74d118185a: 8293785: Add a jtreg test for TraceOptoParse
• 754bd53137a1c596e6f1a7debb847cd563d95699: 8296030: compiler/c2/irTests/TestVectorizeTypeConversion.java fails with release VMs after JDK-8291781
• 1fdbb1ba337b07dbcfb3c28c4fdeba74fee113dc: 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic
• cf5546b3ac63e305c0b9d040353503fb33d6ad7a: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
• 4b89fce0831f990d4b6af5e6e208342f68aed614: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
• d5d34241e21305379f1858556f225e7645cd294e: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@bulasevich Pushed as commit f3ca0cab75f2faf9ec88f7a380490c9589a27102.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.