jcstress
jcstress copied to clipboard
openjdk
7903774: make all tests combinations printing nicer and/or configurable
This is still WIP, but already on row what CODETOOLS-7903774 suggested.
It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable.
From:
`TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact
`ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910
`COMBINATIONS_JSON` same as combinations, but a valid json
`COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed
- TESTS are already implemented as ALL_MATCHING
- COMBINATIONS as ALL_MATCHING_COMBINATIONS
- ALL_TESTS as ALL
COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. The _JSON variants are tobe decided, but ability to JQL it sounds nice.
Suggestion to better names welcomed.
Progress
- [x] Change must not contain extraneous whitespace
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- CODETOOLS-7903774: make all tests combinations printing nicer and/or configurable (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153
$ git checkout pull/153
Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jcstress.git pull/153/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 153
View PR using the GUI difftool:
$ git pr show -t 153
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/153.diff
Using Webrev
:wave: Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
Webrevs
- 09: Full (6f327f73)
- 08: Full - Incremental (b8d0209d)
- 07: Full - Incremental (12cad1b8)
- 06: Full - Incremental (60bbb3e8)
- 05: Full - Incremental (0219ab93)
- 04: Full - Incremental (5006dead)
- 03: Full - Incremental (67b737ba)
- 02: Full - Incremental (a58cd140)
- 01: Full - Incremental (0a2e6c7a)
- 00: Full (d8a3644c)
Implemented COMBINATIONS_GROUPED and COMBINATIONS_GROUPS (as MATCHING_GROUPS and MATCHING_GROUPS_COUNT) also with its inverted variants
The nice json will maybe need some refactorings. WIP on it, but any feedback appreciated
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
I intend to finish this. Still some feedback if it is even desired, and selected approach is ok, would be nice.
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
hi @shipilev ! This is now feature complete for https://github.com/openjdk/jcstress/pull/149#discussion_r1668900808 what do you think?
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Just small recap, why this is done - I wanted to split full load of jcstresses, into several HWs. At least 50, so it can finish in reasonable time. This splitting is done by groups - eg https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml#L1128 - to have those groups equally split, information provided by this PR have to be reasonably accessible.
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@judovana This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!