guide
guide copied to clipboard
Replace affects_versions.png with SVG
Replace affects_versions.png with Scalable Vector Graphics (SVG) image.
PNG vs SVG
PNG:

SVG:
SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04 KB vs 26.24 KB), it's easier to edit and the edit history is preserved.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
Reviewers
- Magnus Ihse Bursie (@magicus - Committer) ⚠️ Review applies to bc65ea67
- Jesper Wilhelmsson (@JesperIRL - Reviewer)
- Iris Clark (@irisclark - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/147/head:pull/147
$ git checkout pull/147
Update a local copy of the PR:
$ git checkout pull/147
$ git pull https://git.openjdk.org/guide.git pull/147/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 147
View PR using the GUI difftool:
$ git pr show -t 147
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/guide/pull/147.diff
Using Webrev
:wave: Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@aivanov-jdk This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
Replace affects_versions.png with SVG
Reviewed-by: ihse, jwilhelm, iris
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 3 new commits pushed to the master branch:
- a7c63ab114348ce25bbe3adb40fc13abb1ed067b: Follow-on update due to the introduction of caused-by links
- 907785214ce3129b5594e1b2b39cd9f4fad20f30: Reminder to remove label
- a0d2befb5e818aacc157a4a12ac5e9a1b74ee719: No localization in RDP2
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus, @JesperIRL, @irisclark) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
Indeed nice! As you are in the area... ;-) I think it would make more sense if case 4 didn't end with an arrow pointing at 12-na, but rather ends with a tilted "T" .. as in "--| 12-na". The arrow could be interpreted as the issue lives on.
…if case 4 didn't end with an arrow pointing at 12-na, but rather ends with a tilted "T" .. as in "--| 12-na". The arrow could be interpreted as the issue lives on.
That's a good idea.
I made it end with with ─┤ and made the line for 12 dashed/dotted.
Should I use the circle as in case 5 for consistency? The circle seem to represent that an issue is fixed in that release, in other words, the issue is fixed in 11, but it's not applicable to 12 and above.
…if case 4 didn't end with an arrow pointing at 12-na, but rather ends with a tilted "T" .. as in "--| 12-na". The arrow could be interpreted as the issue lives on.
That's a good idea.
I made it end with with ─┤ and made the line for 12 dashed/dotted.
The current version with T-like end for ‘12-na’:
Should I use the circle as in case 5 for consistency? The circle seem to represent that an issue is fixed in that release, in other words, the issue is fixed in 11, but it's not applicable to 12 and above.
The version which ends 12-na line with a circle:
Yes actually the circle makes sense as it's consistent with 5.
/integrate
@aivanov-jdk An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.
/integrate
@aivanov-jdk Your change (at version c48bff06cc94e1b55b9db68257b2a2d9f85a9fef) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit b10cd0da8178361841861a24dee0711204883ef8.
Since your change was applied there have been 3 commits pushed to the master branch:
- a7c63ab114348ce25bbe3adb40fc13abb1ed067b: Follow-on update due to the introduction of caused-by links
- 907785214ce3129b5594e1b2b39cd9f4fad20f30: Reminder to remove label
- a0d2befb5e818aacc157a4a12ac5e9a1b74ee719: No localization in RDP2
Your commit was automatically rebased without conflicts.
@JesperIRL @aivanov-jdk Pushed as commit b10cd0da8178361841861a24dee0711204883ef8.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.