guide icon indicating copy to clipboard operation
guide copied to clipboard

Clarify use of (rel)-pool values

Open calnan opened this issue 1 year ago • 4 comments
trafficstars

(rel)-pool values should not be used for affects versions, but can, along with tbd, be used in the fix version


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.org/guide.git pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/guide/pull/134.diff

Webrev

Link to Webrev Comment

calnan avatar Aug 12 '24 17:08 calnan

:wave: Welcome back calnan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 12 '24 17:08 bridgekeeper[bot]

@calnan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Clarify use of (rel)-pool values

Reviewed-by: iris, dholmes, jwilhelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @JesperIRL) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Aug 12 '24 18:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 12 '24 18:08 mlbridge[bot]

:warning: @calnan the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout pool-value-use
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

openjdk[bot] avatar Aug 12 '24 18:08 openjdk[bot]

/integrate

calnan avatar Sep 30 '24 12:09 calnan

@calnan Your change (at version 5a2c6ca80e796e54c77a5b9b0b271239e7895f37) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Sep 30 '24 12:09 openjdk[bot]

/sponsor

JesperIRL avatar Sep 30 '24 22:09 JesperIRL

Going to push as commit 2f922b4814605fcf3837b8b5f2674bf0ba09356e. Since your change was applied there has been 1 commit pushed to the master branch:

  • 361d6cd90d128d3083d81650571b7fc12af4d615: No support questions

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Sep 30 '24 22:09 openjdk[bot]

@JesperIRL @calnan Pushed as commit 2f922b4814605fcf3837b8b5f2674bf0ba09356e.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 30 '24 22:09 openjdk[bot]