crac
crac copied to clipboard
8371250: [CRaC] Remove old pid file in ImageScoreTest
The test is executed twice (with -XX:[+-]UsePerfData), and when the pauseengine pidfile is not removed this could lead to races.
Progress
- [x] Change must not contain extraneous whitespace
Issue
- JDK-8371250: [CRaC] Remove old pid file in ImageScoreTest (Bug - P4)
Reviewers
- Timofei Pushkin (@TimPushkin - Committer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/273/head:pull/273
$ git checkout pull/273
Update a local copy of the PR:
$ git checkout pull/273
$ git pull https://git.openjdk.org/crac.git pull/273/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 273
View PR using the GUI difftool:
$ git pr show -t 273
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/273.diff
Using Webrev
:wave: Welcome back rvansa! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@rvansa This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8371250: [CRaC] Remove old pid file in ImageScoreTest
Reviewed-by: tpushkin
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the crac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.
/integrate
Going to push as commit 3468d77c35a7ff9239381bee07c31d8a5e88fc53.
@rvansa Pushed as commit 3468d77c35a7ff9239381bee07c31d8a5e88fc53.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.